Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 364079

Summary: Javadoc provider for hover has strange inconsistent spacing making it unusable
Product: z_Archived Reporter: Steve Ash <stevemash>
Component: RecommendersAssignee: Marcel Bruch <marcel.bruch>
Status: CLOSED WORKSFORME QA Contact:
Severity: normal    
Priority: P3 CC: lerch, stefan.henss
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
javadoc provider content is unreadable
none
javadoc content somewhat readable but doesnt extend to entire margin none

Description Steve Ash CLA 2011-11-17 14:40:38 EST
Created attachment 207173 [details]
javadoc provider content is unreadable

I'm running Eclipse 3.7 and Recommenders 0.4

I see strange visual issues with the javadoc provider in the hover.  In general, I observe two issues:

1) the javadoc text does not always fill the entire hover space and the space that it does fill is inconsistent.  Often times it is completely unusable (see screenshots).  I have seen it _almost_ fill the whole thing but there always seems to be spacing on the right.

2) We loose a lot of pixels for the text "javadoc provider" ~25% of the vertical distance for the entire provider in one of those screenshots.  In general I would expect the context to make it clear what the provider is, and screen real estate is way more important.  I would support removing these provider labels entirely to maximize the amount of information being displayed.

3) I can't seem to turn off some of the providers.  I always get "code examples" and "social bookmarks" regardless of the settings in my hover preferences.

See attached screenshots for more information.
Comment 1 Steve Ash CLA 2011-11-17 14:41:24 EST
Created attachment 207174 [details]
javadoc content somewhat readable but doesnt extend to entire margin
Comment 2 Marcel Bruch CLA 2011-11-17 18:06:17 EST
Thanks for the pictures Steve.

Stefan, any ideas? Do you have some spare time left to reproduce theses layout glitches and maybe fix them?

Thanks,
Marcel
Comment 3 Stefan Henss CLA 2011-12-01 01:23:05 EST
Hi Steve,

unlike Mac and Windows, Eclipse's Javadoc uses a StyledText instead of a browser widget. That's why our layout strategies did not work for Linux (we "borrow" the original Javadoc composite for our provider).

I've now improved the behavior (see current master branch) to full vertical extend and a dynamic height. Unfortunately, vertical and horizontal scroll bars can't yet be disabled, which looks bad and wastes space. But according to https://bugs.eclipse.org/bugs/show_bug.cgi?id=27096, we should be able to hide the scroll bars with one of the next Eclipse SWT releases.
Comment 4 Marcel Bruch CLA 2012-02-02 01:27:56 EST
Steve, 

the hover has been (temporarily) disabled for 0.5. Do you mind checking whether the Extdoc view (as replacement for the Javadoc View) works as expected?
Comment 5 Marcel Bruch CLA 2012-03-05 17:38:17 EST
Didn't hear back. Closing with "works for me".