Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 363956

Summary:	Remove unused code (<2.4.x) in Combo
Product:	[Eclipse Project] Platform	Reporter:	Silenio Quarti <Silenio_Quarti>
Component:	SWT	Assignee:	Alexander Kurtakov <akurtakov>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	akurtakov, arunkumar.thondapu, gheorghe, sbasalaev
Version:	3.8
Target Milestone:	3.8 M4
Hardware:	PC
OS:	Linux
Whiteboard:
Bug Depends on:
Bug Blocks:	340067

Description Silenio Quarti

2011-11-16 13:57:56 EST

Need to remove all the code in Combo that runs only when the version is less than 2.4.

This is to continue the work start in bug#360872 and bug#361004.

Comment 1 Silenio Quarti

2011-11-16 14:05:36 EST

Alexander, please could make these changes?

Also after all the unused code is removed, we should fix the indentation.

Comment 2 Alexander Kurtakov

2011-11-16 14:28:21 EST

Sure, I'll do it

Comment 3 Alexander Kurtakov

2011-11-21 09:18:36 EST

Here are the requested changes.
http://fedorapeople.org/gitweb?p=akurtakov/public_git/eclipse.platform.swt.git;a=commit;h=d6f1ad6388435d1b64a45c01d0e8cb19a8ec6e73
According to http://wiki.eclipse.org/Development_Resources/Handling_Git_Contributions it is fine to just point to the release but if you prefer to have patches let me know

Comment 4 Silenio Quarti

2011-11-25 09:54:39 EST

Pushed changes to git.eclipse.org
http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=5014eebfedd0f623cdc5c8c21ddc6fda2b771129

Thanks Alex.  Please put the bug number in your commit comments. It helps us track the bug associated to the changed. Usually we just copy the description above as the commit comment:

"Bug 363956 - Remove unused code (<2.4.x) in Combo"

Comment 5 Alexander Kurtakov

2011-11-25 10:03:19 EST

OK, will do. Though upto now I had a different workflow. Commit to my git repo and once I"m satisfied with the changes open bug report