Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 363904

Summary:	First page of 'Push...' dialog should not enable 'Finish'
Product:	[Technology] EGit	Reporter:	Dani Megert <daniel_megert>
Component:	UI	Assignee:	Project Inbox <egit.ui-inbox>
Status:	REOPENED ---	QA Contact:
Severity:	normal
Priority:	P3	CC:	dariusz.luksza
Version:	1.2
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:

Description Dani Megert

2011-11-16 06:36:42 EST

1.2.

1. select a repository in the Git Repositories view
2. context menu Push...
   ==> 'Finish' is enabled
3. click 'Finish'
==> now all my local branches are pushed to the repository.


'Finish' should be disabled because:
1. of the above scenario where all local branches get pushed
2. after pressing 'Next' it gets disabled which is strange
3. clicking it does not the same as clicking Next + Finish

Comment 1 Stefan Lay

2011-11-16 10:00:47 EST

(partial) fix proposed: http://egit.eclipse.org/r/#change,4626. This fixes the problem that all branches are pushed if no refspec is configured.
Instead it uses the default of JGit's push command, which is (at the moment) to
push the currently checked out branch.

The finish button is disabled after pressing 'Next' if no push refspec is configured. 
I think we should enable it also on this page and do the same as on the first page, using the default refspec.

I don't understand "3. clicking it does not the same as clicking Next + Finish": When the Finish button is disabled you cannot click Finish but you have to add a refspec before. In that case it is clear that the behavior is different.

Comment 2 Dani Megert

2011-11-16 10:20:58 EST

(In reply to comment #1)
> (partial) fix proposed: http://egit.eclipse.org/r/#change,4626. This fixes the
> problem that all branches are pushed if no refspec is configured.
> Instead it uses the default of JGit's push command, which is (at the moment) to
> push the currently checked out branch.
> 
> The finish button is disabled after pressing 'Next' if no push refspec is
> configured. 
> I think we should enable it also on this page and do the same as on the first
> page, using the default refspec.

Sounds good.

 
> I don't understand "3. clicking it does not the same as clicking Next +
> Finish": When the Finish button is disabled you cannot click Finish but you
> have to add a refspec before. In that case it is clear that the behavior is
> different.
Yeah, I guess that's just repeating point 2 and will get fixed by your proposal.

Comment 3 Dariusz Luksza

2011-11-18 17:03:18 EST

Merged as commit bb8154b159b76ae3442dbe6d386ffcef667fe9b9

Comment 4 Dani Megert

2011-11-21 06:21:04 EST

Verified in 1.2.0.201111201913 that the first part of the fix is in but the second one is not yet there (see comment 1 for details).