Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 363896

Summary: Generated plugin.xml contains mixed spaces/tabs
Product: [Modeling] TMF Reporter: Karsten Thoms <karsten.thoms>
Component: XtextAssignee: Karsten Thoms <karsten.thoms>
Status: RESOLVED FIXED QA Contact:
Severity: trivial    
Priority: P3 CC: btickets, martin.gerhardy, sebastian.zarnekow, tmf.xtext-inbox
Version: 2.1.1   
Target Milestone: ---   
Hardware: PC   
OS: Mac OS X - Carbon (unsup.)   
See Also: https://git.eclipse.org/r/43526
Whiteboard:
Attachments:
Description Flags
Screenshot none

Description Karsten Thoms CLA 2011-11-16 02:10:12 EST
Created attachment 207083 [details]
Screenshot

The plugin.xml file generated for the UI project contains a mixture of whitespaces. It should produce either tabs or spaces only for indentation.
Comment 1 Eclipse Genie CLA 2015-03-10 06:46:20 EDT
New Gerrit change created: https://git.eclipse.org/r/43526

WARNING: this patchset contains 1147 new lines of code and may require a Contribution Questionnaire (CQ) if the author is not a committer on the project. Please see:https://wiki.eclipse.org/Project_Management_Infrastructure/Creating_A_Contribution_Questionnaire
Comment 2 Karsten Thoms CLA 2015-03-10 06:51:04 EDT
The patch will consequently replace space indentations by tabs. Most templates used 4 spaces, but some also 3 or 2. Most template code was already using tabs.

Further did some refactoring on the indentation.

Moved attribute 'point' to the same line as '<extension'. This was partially the case, but some extensions broke this to a new line.

Shortened usage of reference:
  <reference
     definitionId="«name».Editor.opened">
  </reference>

=>

  <reference definitionId="«name».Editor.opened"/>
Comment 3 Karsten Thoms CLA 2016-08-15 15:18:04 EDT
*** Bug 378982 has been marked as a duplicate of this bug. ***
Comment 4 Karsten Thoms CLA 2016-09-05 22:46:30 EDT
The new generator does only generate tabs into the plugin.xml file. It is not necessary to fix this also for the old generator, thus I consider the bug as fixed.