Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 363892

Summary:

On the Server / Web Modules page, Auto Reload is enabled by default. It would be nice to have the option to make it disabled by default instead. PATCH INCLUDED - I've written a patch to add this feature.

Product:

[WebTools] WTP ServerTools

Reporter:

Grant <grant>

Component:

jst.server

Assignee:

Elson Yuen <eyuen7>

Status:

RESOLVED FIXED

QA Contact:

Elson Yuen <eyuen7>

Severity:

enhancement

Priority:

CC:

karl

Version:

unspecified

Target Milestone:

3.4

Hardware:

All

OS:

All

See Also:

https://git.eclipse.org/r/109107

Whiteboard:

Attachments:

Description	Flags
A patch file for org.eclipse.jst.server.tomcat.core	eyuen7: iplog+
A patch file for org.eclipse.jst.server.tomcat.ui	eyuen7: iplog+, eyuen7: review+
A patch file for org.eclipse.jst.server.tomcat.core - v1.0	eyuen7: review+

Description Grant

2011-11-16 00:14:05 EST

Build Identifier: 20110916-0149

Auto Reload is generally a nice idea, but isn't always desirable, especially for Tomcat 5.5 which suffers from memory leaks.  I've added a configuration checkbox to allow the user to change the default for their server.  

I have a patch that implements this configuration option.  I'll attach that ASAP.

Reproducible: Always

Steps to Reproduce:
1. Open the Servers view
2. Right-click a server, and select "Add and Remove..."
3. double-click one of the available Web Modules to add it to the Configured side.
4. Click "Finish"
5. Double-click the server to open the Web Modules page
6. Select the "Modules" tab
7. Notice that "Auto Reload" is Enabled by default.

Comment 1 Grant

2011-11-16 00:16:29 EST

Created attachment 207079 [details]
A patch file for org.eclipse.jst.server.tomcat.core

This patch should be used in conjunction with the org.eclipse.jst.server.tomcat.ui patch.

Comment 2 Grant

2011-11-16 00:17:25 EST

Created attachment 207080 [details]
A patch file for org.eclipse.jst.server.tomcat.ui

To be used in conjunction with the org.eclipse.jst.server.tomcat.core patch, also included.

Comment 3 Elson Yuen

2012-04-18 14:52:53 EDT

Created attachment 214203 [details]
A patch file for org.eclipse.jst.server.tomcat.core - v1.0

The patches looks good in general except the default value should always be true to make sure we don't cause change in behaviour in existing scenario. The new replacement patch is based on the original patch with the default value changed.

Comment 4 Elson Yuen

2012-04-18 15:02:43 EDT

Thanks for submitting the patch.   Changes released to HEAD

Comment 5 Elson Yuen

2012-04-18 15:11:39 EDT

I also notice the redo undo message is missing so I added the missing message to HEAD as well.

Comment 6 Eclipse Genie

2017-10-11 16:38:12 EDT

New Gerrit change created: https://git.eclipse.org/r/109107