Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 363836

Summary: [prefs] Don't write date/timestamp comment in preferences file
Product: [Eclipse Project] Equinox Reporter: DJ Houghton <dj.houghton>
Component: CompendiumAssignee: DJ Houghton <dj.houghton>
Status: RESOLVED FIXED QA Contact:
Severity: minor    
Priority: P3 CC: cgamache, Daniel.Ebert, dcendents, dj.houghton, geeky.diamond, igor, john.arthorne, mober.at+eclipse, pwebster, Szymon.Brandys, tjwatson, wbprio
Version: 3.6.2Flags: Szymon.Brandys: review+
Target Milestone: 3.7.2   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on: 342709    
Bug Blocks:    

Description DJ Houghton CLA 2011-11-15 10:25:00 EST
Cloned to track release into R3.7.x branch.

+++ This bug was initially created as a clone of Bug #342709 +++

Build Identifier: 20110301-1815

Changes to the org.maven.ide.eclipse.prefs file include a timestamp update on each change. We frequently toggle workspace resolution mode, which causes a timestamp update which creates a red-herring SCM change (nothing has changed except for the timestamp). For us, the timestamp is not necessary and is more of a hindrance than a help. Would you consider eliminating it? If not, perhaps a configuration option can be added to ignore the timestamp and not perform an update?


Reproducible: Always

Steps to Reproduce:
1.Create a new maven project
2.Note the timestamp in .settings/org.maven.ide.eclipse.prefs 
3.Change the maven config
4.Note the new timestsamp in .settings/org.maven.ide.eclipse.prefs
Comment 1 DJ Houghton CLA 2011-11-15 15:50:28 EST
Szymon, are you ok with this change for 3.7.x?
Comment 2 Thomas Watson CLA 2012-01-04 11:25:53 EST
(In reply to comment #1)
> Szymon, are you ok with this change for 3.7.x?

So Szymon, last chance.  Do you want this in 3.7.x?
Comment 3 Szymon Brandys CLA 2012-01-11 09:32:37 EST
(In reply to comment #2)
> (In reply to comment #1)
> > Szymon, are you ok with this change for 3.7.x?
> 
> So Szymon, last chance.  Do you want this in 3.7.x?

Looks good, but I can't find any tests... Are there any?
Comment 4 DJ Houghton CLA 2012-01-11 10:15:29 EST
No, there aren't any tests yet.
Comment 5 Szymon Brandys CLA 2012-01-11 15:04:21 EST
(In reply to comment #4)
> No, there aren't any tests yet.

+1. Just add a test, please.