Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 363834

Summary: [Bidi] STextProcessor: Test failures testSomeMore, testSTextProcessor
Product: [Eclipse Project] Equinox Reporter: Oleg Besedin <ob1.eclipse>
Component: ComponentsAssignee: equinox.components-inbox <equinox.components-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: matial
Version: unspecified   
Target Milestone: Juno M4   
Hardware: All   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard:

Description Oleg Besedin CLA 2011-11-15 09:50:04 EST
The tests fail because Mac OS is not listed in the supported operating systems, see STextEnvironment#isProcessingNeeded() :

boolean supportedOS = osName.startsWith("windows") || osName.startsWith("linux"); 

While the value of osName on the Mac is "mac os x".

If I add "|| osName.startsWith("mac")" tests pass.
Comment 1 Matitiahu Allouche CLA 2011-11-15 10:56:28 EST
(In reply to comment #0)
> The tests fail because Mac OS is not listed in the supported operating systems,
> see STextEnvironment#isProcessingNeeded() :
> 
> boolean supportedOS = osName.startsWith("windows") ||
> osName.startsWith("linux"); 
> 
> While the value of osName on the Mac is "mac os x".
> 
> If I add "|| osName.startsWith("mac")" tests pass.

Please add the check for "mac os x". This does not mean that Mac OS supports bidi in general to the same extent as Windows or even Linux, but if all the SText tests pass, we can state that this component is supported on Mac OS.
Comment 2 Oleg Besedin CLA 2011-11-15 11:00:41 EST
Done. Also the TextProcessor includes "mac" into the list.

http://git.eclipse.org/c/equinox/rt.equinox.bundles.git/commit/?id=4fa68b899a09f5e72120fb8829bbdfc4d89f1473