Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 363828

Summary:

Improved Table Column Management

Product:

z_Archived

Reporter:

Adrian Moser <trekking09>

Component:

Scout

Assignee:

Project Inbox <scout.core-inbox>

Status:

CLOSED FIXED

QA Contact:

Severity:

enhancement

Priority:

CC:

zimmermann

Version:

unspecified

Flags:

zimmermann: juno+

Target Milestone:

---

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Proposed patch.	stephan.leichtvogt: iplog+
Swing Icons	stephan.leichtvogt: iplog+
SWT Icons	stephan.leichtvogt: iplog+
Missing Texts	none
Organize Columns - Proposed Patch	none
Improved Swing Icons	stephan.leichtvogt: iplog+
Organize Columns - Proposed Patch	stephan.leichtvogt: iplog+
Proposed Bugfix	none
Patch changed to Workspace Patch	stephan.leichtvogt: iplog+

Description Adrian Moser

2011-11-15 09:23:23 EST

Build Identifier: M20110210-1200

Currently it is not possible to edit all column settings (visibility, ascending, descending, order, custom columns, filtering) in one place.

The proposed patch enhances the Column Management Dialog by allowing
- changing visiblity
- ascending, descending sort order
- change of column order by drag'n'drop or buttons
- changing the column filter
- adding custom columns
- resetting any of the settings

The table is enhanced by
- showing an icon for custom columns (Swing)
- showing number of filtered rows in footer (all)

Reproducible: Always

Comment 1 Adrian Moser

2011-11-15 09:26:32 EST

Created attachment 207027 [details]
Proposed patch.

Comment 2 Stephan Leicht Vogt

2011-11-15 10:06:50 EST

Hi Adrian
Please attach the icons in a zip to the bug. They are invalid as submitted via patch-file.
Thanks

Comment 3 Adrian Moser

2011-11-15 10:06:54 EST

Created attachment 207031 [details]
Swing Icons

Comment 4 Adrian Moser

2011-11-15 10:07:23 EST

Created attachment 207032 [details]
SWT Icons

Comment 5 Stephan Leicht Vogt

2011-11-15 10:13:23 EST

Thanks for the patch. I reviewed and applied it to trunk for Eclipse 3.8

Comment 6 Stephan Leicht Vogt

2011-11-16 08:34:53 EST

Created attachment 207087 [details]
Missing Texts

Hi Adrian
There are texts missing. I made a screenshot of the test-application. Please add them to the shared plugin and attach the patch.
Thanks

Comment 7 Stephan Leicht Vogt

2011-11-16 08:36:07 EST

Task reopened -> see last comment for screenshot.

Comment 8 Matthias Zimmermann

2011-11-17 06:39:17 EST

Please consider to present the full configuration to the user. Currently the user is only presented with the overview of the visibility and ordering of the available columns.

Missing are the following points:
- indication of defined column filters
- indication of dynamically addes columns
- indication of sort orders (none, a-z, z-a) and sort criteria ordering

Comment 9 Adrian Moser

2011-11-29 09:35:56 EST

Created attachment 207654 [details]
Organize Columns - Proposed Patch

Comment 10 Adrian Moser

2011-11-29 09:36:25 EST

Created attachment 207655 [details]
Improved Swing Icons

Comment 11 Adrian Moser

2011-11-29 09:44:43 EST

Patch submitted (att. 207654) with following improvements/fixes:
- missing texts added
- icon for custom columns improved
- sort icons are now displayed in different shades respecting their order
- sort index is shown in development mode
- column filters are stored in UI preferences
- column filters are stored in bookmarks
- organize column form: improved, smaller GUI
- cleaned-up 'reset columns' menu
- removed SortBox from column filter form, replaced by 
  sort functionality on organize columns form

Please note:
- SVN patch does not include binary resources, please use the zip file 
  (attachment 207655 [details])
- SWT and RAP does not offer yet the same functionality as Swing

Comment 12 Stephan Leicht Vogt

2011-11-30 02:26:42 EST

I'm sorry, but the patch doesn't apply anymore. Please update the patch-file and do not include the changes from the icons. I'll use the icons from the zip file.

Comment 13 Adrian Moser

2011-11-30 03:41:55 EST

Created attachment 207706 [details]
Organize Columns - Proposed Patch

Create new patchfile without binary resources.

Comment 14 Stephan Leicht Vogt

2011-11-30 05:34:29 EST

Thanks for the patch. I reviewed and applied it to trunk for Eclipse 3.8

Comment 15 Adrian Moser

2011-12-06 05:24:03 EST

Created attachment 207961 [details]
Proposed Bugfix

The proposed patch fixes the following issues introduced with this ticket:
- A filter created on the Label column of a node page 
  did apply to all node pages after restart, 
  because the label columns of node pages share the same UI pref key
- this is unwanted behaviour, therefore the parent of the node page 
  is considered in the patch as well
- resetting the column filter by menu did not propagate the change to the UI prefs

Comment 16 Adrian Moser

2011-12-06 05:24:40 EST

Ticket reopened due to attachment 207961 [details]

Comment 17 Adrian Moser

2011-12-06 09:16:19 EST

Created attachment 207989 [details]
Patch changed to Workspace Patch

Patch changed to Workspace Patch

Comment 18 Stephan Leicht Vogt

2011-12-06 10:31:49 EST

Thanks for the patch. I reviewed and applied it to trunk for Eclipse 3.8

Comment 19 Matthias Zimmermann

2012-07-09 06:50:51 EDT

ticket closed.
deliverd as part of eclipse scout 3.8.0 (juno release train)