Bugzilla – Full Text Bug Listing
| Summary: | Several string variables in properties files not OK | ||
|---|---|---|---|
| Product: | [Technology] JGit | Reporter: | Dani Megert <daniel_megert> |
| Component: | JGit | Assignee: | Project Inbox <jgit.core-inbox> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | remy.suen |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Whiteboard: | |||
Note that there might be rare situations where no quotes are needed but those are rare. I pushed a fix that corrects the third case where a single ' was being used: http://egit.eclipse.org/r/#change,4624 >==> use ''{0}'' at all places and '' for single quotes on lines with variables
Just to clarify: this is mostly when you refer to resource or other named entities. If it's e.g. a number or something else then no quotes are needed.
This has been merged some time ago: http://git.eclipse.org/c/jgit/jgit.git/commit/?id=1b472a7954f2614698f1e7295172a97a63050c46 |
1.2. Variables inside strings should be in single quotes. There are several mistakes in the JGit properties files: - some variables have no quotes at all - some variables use double quotes - some variables use ' which is not OK because single quotes need to be escaped by '. This is also true for all other single quotes on the same line. ==> use ''{0}'' at all places and '' for single quotes on lines with variables