Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 363697

Summary: Clean Up in AbstractOutlineViewButton
Product: z_Archived Reporter: Ralph Steiner <steiner.ralph>
Component: ScoutAssignee: Project Inbox <scout.core-inbox>
Status: CLOSED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: zimmermann
Version: unspecifiedFlags: zimmermann: juno+
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Suggested Patch stephan.leichtvogt: iplog+

Description Ralph Steiner CLA 2011-11-14 09:26:38 EST
Created attachment 206947 [details]
Suggested Patch

The code in the class AbstractOutlineViewButton looks strange. There is a mix between a proptery m_desktop an the usage of ClientJob.getCurrentSession().getDesktop(). If the property is needed, i would suggest the changes provided in the patch. Additionaly the property m_outline could be set to final.
Comment 1 Stephan Leicht Vogt CLA 2011-11-15 03:48:38 EST
Thanks for the patch. I reviewed and applied it to trunk for Eclipse 3.8
Comment 2 Matthias Zimmermann CLA 2012-07-09 06:50:12 EDT
ticket closed.
deliverd as part of eclipse scout 3.8.0 (juno release train)