Bugzilla – Full Text Bug Listing
| Summary: | [API] Add toolchain accessor functions to MBSWizardHandler | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Tools] CDT | Reporter: | John Eblen <jdeblen1> | ||||||||
| Component: | cdt-build-managed | Assignee: | Chris Recoskie <recoskie> | ||||||||
| Status: | RESOLVED FIXED | QA Contact: | Chris Recoskie <recoskie> | ||||||||
| Severity: | enhancement | ||||||||||
| Priority: | P3 | CC: | beth, cdt-build-managed-inbox, cdtdoug, g.watson, jeblen, roland | ||||||||
| Version: | 8.1.0 | ||||||||||
| Target Milestone: | --- | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
I just wanted to ask if someone is reviewing this patch. It is a small API change (about 20 lines of code) needed for the new synchronized project wizard. Since this class is API you will have to add some Javadoc including @since tags. I suggest you set an API baseline for your workspace so that you can see any API tooling errors (like the ones I saw about missing @since tags). Created attachment 209461 [details]
Patch with javadoc added
Added javadoc to patch.
Arg, now the patch doesn't apply. Can you update your repo and regenerate it? Created attachment 210012 [details]
Patch with javadoc added
Updating the repo and regenerating the patch had no effect, so I'm not sure why the previous patch didn't apply. This new patch excludes prefixes and so may be more Eclipse-friendly.
Please try the new patch and let me know if you have any further problems. Thanks! Chris, If you're ok with this patch, can you apply it? Thanks, Greg Chris? (In reply to comment #7) > Chris, > > If you're ok with this patch, can you apply it? > > Thanks, > Greg Sorry this has kind of fallen through the cracks. We are past API freeze right now unfortunately. You could put a request on cdt-dev asking if people are ok with the changes. I don't think it will be a problem given these are additions only, but the protocol must be followed. The patch is now on Gerrit: https://git.eclipse.org/r/#/c/5870/ If I did things right, Gerrit should hopefully have cherry picked this into master. |
Created attachment 206869 [details] Patch The attached patch adds accessor functions to MBSWizardHandler to get the handler's toolchains (a map of toolchain names to actual toolchains). There is also a function to get the table used in the local toolchain view. This allows wizards to filter and modify the view's contents. The motivation for this change is to improve the new project wizard for PTP synchronized projects. This wizard should allow users to select both a local toolchain and a remote toolchain, so two toolchain views are needed. Since each handler does project-specific toolchain filtering, the remote toolchain list also needs to be provided by the handler. Having access to the table allows the sync wizard to filter unsupported toolchains after the handler is created for the local toolchains view, while still having the full list for the remote toolchains view.