| Summary: | [Xtend] Remove dependency on Google Guice | ||
|---|---|---|---|
| Product: | [Modeling] TMF | Reporter: | Peter Kriens <Peter.Kriens> |
| Component: | Xtext | Assignee: | Project Inbox <tmf.xtext-inbox> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | sven.efftinge |
| Version: | 2.1.0 | Flags: | sven.efftinge:
juno+
|
| Target Milestone: | M4 | ||
| Hardware: | PC | ||
| OS: | Mac OS X - Carbon (unsup.) | ||
| Whiteboard: | |||
| Bug Depends on: | 364123 | ||
| Bug Blocks: | |||
|
Description
Peter Kriens
The dependency to google inject is optional and there to advocate the use of it. But you are right that there is no runtime or compile time dependency. Does it cause you any trouble? Yes, it does. I am not using xtend with PDE, I use bndtools. With bndtools we want to minimize dependencies as much as possible. However, I now get an error when I do not include Google Guice on the classpath. Ok, I think we should reconsider having it, but I wonder why bnd complains although it's marked optional. Is that an equinox-specific option? I realized that we actually have a compiler check which checks for google guice. We should get rid of the check and also should remove the dependency. I removed the compiler check. Yup, that was the problem. Thanks! Looking forward to work more with xtend! There is a new library bundle (org.eclipse.xtend2.lib) which doesn't depend on com.google.inject. Closing all bugs that were set to RESOLVED before Neon.0 Closing all bugs that were set to RESOLVED before Neon.0 |