Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 363490

Summary:

PHP files opening in system editor (Dreamweaver)

Product:

[Tools] Target Management

Reporter:

Jonathan Amend <j.amend>

Component:

RSE

Assignee:

David McKnight <dmcknigh>

Status:

RESOLVED FIXED

QA Contact:

Martin Oberhuber <mober.at+eclipse>

Severity:

normal

Priority:

CC:

dmcknigh

Version:

unspecified

Target Milestone:

3.4 M4

Hardware:

Macintosh

OS:

Mac OS X - Carbon (unsup.)

Whiteboard:

Attachments:

Description	Flags
patch to use name to get editor descriptor when no cached file	none
updated patch	none

Description Jonathan Amend

2011-11-10 11:03:49 EST

Build Identifier: TM 3.3.1.R33x_v201109141647, PDT 3.0.2.v2011102768, Eclipse 3.7.1.r37x_v20110729

PHP files on a Linux host over SSH are opening in the system editor (Dreamweaver in my case) instead of the PHP editor. This seems to only happen for files that are not already in my RemoteSystemsTempFiles.

If I go right click the file and go to open with, it has PHP Editor checked by default, but double-clicking the file still opens it in the system editor unless I actually click on PHP Editor. Also, the files already in my RemoteSystemsTempFiles (since I'm using a workspace I made in 3.6) have a normal PHP file icon, whereas the files not in RemoteSystemsTempFiles and opening in the system editor have an extra "101" overlayed on the icon that I'm guessing means it thinks it's binary instead of text. The files are all encoded as UTF-8.

Files in the project explorer from the local file system open up correctly.
I didn't have this problem in Eclipse 3.6/PDT 2.2/TM 3.2.

Reproducible: Always

Steps to Reproduce:
1. Open a PHP file on a remote host (only tried Linux/SSH) encoded as UTF-8 that's not in the RemoteSystemsTempFiles cache.

Comment 1 David McKnight

2011-11-11 16:38:09 EST

Created attachment 206878 [details]
patch to use name to get editor descriptor when no cached file

Comment 2 David McKnight

2011-11-11 16:38:37 EST

Jonathan, could you see if the attached patch resolves your scenario?

Comment 3 David McKnight

2011-11-14 12:35:12 EST

Created attachment 206966 [details]
updated patch

Comment 4 David McKnight

2011-11-15 18:35:05 EST

I've committed the patch to the HEAD stream.  If you still run into problems after getting the fix, feel free to reopen this one.  Also let me know if this needs to be backported.

Comment 5 Jonathan Amend

2011-11-16 09:01:09 EST

Thanks! I installed 3.4.0.N20111116 and now it's working properly. The problem started when I tried to upgrade to Eclipse 3.7/TM 3.3 so it might be worth backporting to 3.3 for anyone else who has the problem.