Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 363474

Summary: Change first parm of StrLib.getNextToken and StrLib.indexOf to IN
Product: z_Archived Reporter: Paul Harmon <pharmon>
Component: EDTAssignee: Project Inbox <edt.javascriptgen-inbox>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: hjiyong
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
new StrLib.js none

Description Paul Harmon CLA 2011-11-10 09:34:14 EST 
The first parm of the functions named in the summary are currently marked as INOUT. This was done in RBD to aid in the resolution of the overloaded functions (presumably when the types of arguments passed to the functions were mixed, such as String and Char).

In EDT, these functions are not currently overloaded, and when they are overloaded, our resolution rules should only used the types of the arguments to resolve the function, not the parameter modifiers.
Comment 1 Paul Harmon CLA 2011-11-10 14:49:35 EST 
Attached is the new StrLib.js that is generated after I made the changes. Note that there are several other differences between this version and the version that is in CVS.

Please check through the differences to make sure that this library still works correctly in JS.

If not, then some other changes to JS gen must be negatively affecting this library.
Comment 2 Paul Harmon CLA 2011-11-10 14:50:52 EST 
Created attachment 206812 [details]
new StrLib.js
Comment 3 Huang Ji Yong CLA 2011-11-12 04:43:25 EST 
The difference can be generalized to 2 types: 
1. the boxing/unbox of the nullable type. I think such change is caused by the js gen change and it is expected.
2. The change of inout parameter to in parameter
I test the new js within the EUnit and didn't find any issue, so commit it.
Comment 4 Paul Harmon CLA 2011-11-18 09:25:28 EST 
done