Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 363468

Summary:	Configure... on Push and Push to Upstream should match the current spec
Product:	[Technology] EGit	Reporter:	Dani Megert <daniel_megert>
Component:	UI	Assignee:	Stefan Lay <stefan.lay>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	dariusz.luksza, deepakazad, markus.kell.r, remy.suen
Version:	1.2
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:

Description Dani Megert

2011-11-10 09:10:35 EST

1.2.

'Push' and 'Push to Upstream' only push the checked out branch - which is good. But, when one chooses 'Configure...' in the 'Push Results' dialog, it starts with a push spec that pushes all branches. This is quite misleading and can result in all local branches being pushed.

Comment 1 Stefan Lay

2011-11-16 02:29:33 EST

That's true.

The description in the dialog and the behavior of the dry-run are wrong and do not match the default behavior of 'Push' and 'Push to Upstream'.

I still don't see why it can result in all local branches being pushed. When you leave the Refspec field as it is 'Push' and 'Push to Upstream' will only push the checked out branch.

Comment 2 Dani Megert

2011-11-16 03:01:11 EST

> I still don't see why it can result in all local branches being pushed. When
> you leave the Refspec field as it is 'Push' and 'Push to Upstream' will only
> push the checked out branch.
Right, but if after the "normal" push in the result dialog you do

1. click 'Configure...'
2. click 'Dry-Run'
==> it says that all local branches will be pushed!

But guess what? I now tried
3. click 'Save and Push'
and this indeed did not push the branches unlike indicated by the dry-run.

Comment 3 Stefan Lay

2011-11-16 03:13:42 EST

Fix proposed:  http://egit.eclipse.org/r/4625

Comment 4 Dariusz Luksza

2011-11-18 17:00:56 EST

Merged as commit a8558f4ec0b2c578b7bc0f514d9e0f8b3035724d

Comment 5 Dani Megert

2011-11-21 06:16:45 EST

Verified in 1.2.0.201111201913.