Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 363371

Summary:	Import wizard project filter filters on repo path too
Product:	[Technology] EGit	Reporter:	DJ Houghton <dj.houghton>
Component:	UI	Assignee:	Project Inbox <egit.ui-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	matthias.sohn, remy.suen, robin
Version:	1.2
Target Milestone:	3.0
Hardware:	PC
OS:	Mac OS X - Carbon (unsup.)
Whiteboard:

Description DJ Houghton

2011-11-09 14:24:10 EST

Eclipse EGit	1.2.0.201111081109	org.eclipse.egit.feature.group	Eclipse EGit

- File -> Import -> Project from Git
- Next until you get to the list of projects
- Deselect All

Now when you enter text into the filter field it filters out based on everything, which in this case is both the project name and the location in the file-system. So if you happen to choose a search filter which matches the path of your repo (e.g. p2), then every project in the list is matched.

I would recommend either only matching on project name or removing the repo location from the display. (or removing the common prefix) Is it really needed? I tried but I could only get to this page by selecting a single repository, so I assume that all the paths will have the same prefix?

Comment 1 Robin Stocker

2013-05-26 16:20:05 EDT

Thanks for the report, I like the suggestion.

As this part of the wizard is similar to the Import Existing Projects page of Eclipse Platform, I think we shouldn't change the way the projects are listed.

But as you said, we could only match the distinct parts of the texts, I pushed a fix to review for this:

https://git.eclipse.org/r/13160

Comment 2 Matthias Sohn

2013-05-26 19:15:11 EDT

merged as 80cd7804b998e91ba019a4701b83ff96f8837cc6