Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 363316

Summary: Patch Contents tree disappears when clicking on element
Product: [Modeling] EMFCompare Reporter: Nicolas Bros <nicolas.bros>
Component: CoreAssignee: EMF Compare <emf.compare-inbox>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: laurent.goubet, malgorzata.tomczyk, tomasz.zarna
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
the patch with which the issue occurs
none
screenshot 1 : before click
none
screenshot 2 : after click
none
screenshot 3: apply patch dialog that doesn't have an error. none

Description Nicolas Bros CLA 2011-11-09 09:33:47 EST
Created attachment 206693 [details]
the patch with which the issue occurs

In the patch wizard (org.eclipse.compare.internal.patch.PatchWizardDialog), when I click on a file in the "Patch Contents" tree, the tree disappears.
This bug may be linked to EMF Compare that opens to show the ecore file comparison in the dialog.

See the attached before/after screenshots.

Eclipse SDK
Version: 3.7.1
Build id: M20110909-1335
Comment 1 Nicolas Bros CLA 2011-11-09 09:34:14 EST
Created attachment 206694 [details]
screenshot 1 : before click
Comment 2 Nicolas Bros CLA 2011-11-09 09:34:32 EST
Created attachment 206695 [details]
screenshot 2 : after click
Comment 3 Tomasz Zarna CLA 2011-11-10 06:07:25 EST
Nicolas, where can I get the sources for org.eclipse.emf.facet.efacet.catalog and org.eclipse.emf.facet.efacet.core projects from? I would like to check if applying the patch you submitted in plain vanilla Eclipse will also make the tree disappear. Or maybe you can do it, do you have an installation of Eclipse Classic at hand?
Comment 5 Tomasz Zarna CLA 2011-11-10 06:52:40 EST
Gosia, please take a look on what's going on here.
Comment 6 Malgorzata Janczarska CLA 2011-11-14 13:24:07 EST
Created attachment 206969 [details]
screenshot 3: apply patch dialog that doesn't have an error.

I was unable to reproduce this bug with standard compare dialog. I'm attaching a screenshot how does it look like in it.
Nicolas, do you have any errors in your log?
Does the problem occur if you click any file (for instance *.java) or does it only apply to those opened with EMF Compare?
Comment 7 Nicolas Bros CLA 2011-11-15 02:59:20 EST
(In reply to comment #6)
> Nicolas, do you have any errors in your log?
No, I haven't seen any related errors.

> Does the problem occur if you click any file (for instance *.java) or does it
> only apply to those opened with EMF Compare?
To clarify: I don't have this problem most of the time. But it happens all the time with the specific scenario demonstrated by the screenshots attached to this bug:
- Install EMF Compare (I believe the bug is linked to EMF Compare)
- Apply the attached patch
- Click "Selected Resource(s) only" in the EMF Compare dialog box that pops up
- The compare dialog opens with efacetcatalog2.ecore selected initially, and it displays its differences using EMF Compare
- double-click on a Java file
=> that's when the patch contents tree disappears
Comment 8 Malgorzata Janczarska CLA 2011-11-15 04:38:33 EST
After installing EMF Compare I managed to reproduce this problem.
Actually the top panel diapers when I select any file other than *.ecore.
Comment 9 Szymon Brandys CLA 2011-11-18 06:01:53 EST
Would be good to verify if it is a Compare or EMF problem.
Comment 10 Nicolas Bros CLA 2011-11-18 06:20:05 EST
I have found a workaround : I commented all the extensions in the plugin.xml of org.eclipse.emf.compare.ui. This effectively disables the UI contributions of EMF Compare (but I still need EMF Compare because of dependencies).
Comment 11 Laurent Goubet CLA 2011-11-21 04:52:55 EST
This is indeed an EMF Compare bug. I have fixed a similar issue recently, I'll check whether this scenario is still reproducible with the latest development version.
Comment 12 Laurent Goubet CLA 2012-03-06 06:09:17 EST
Sorry for the time it took, this was indded fixed from EMF Compare side and cannot be reproduced any more.
Comment 13 Laurent Goubet CLA 2013-01-17 08:32:32 EST
batch-closing a bunch of "RESOLVED" bugs.