| Summary: | Mangling of source jars retrieved from maven fails on Windows | ||||||
|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Michal Ruzicka <michal.ruza> | ||||
| Component: | Buckminster | Assignee: | buckminster.core-inbox <buckminster.core-inbox> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | thomas | ||||
| Version: | unspecified | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Looks good to me. I suggest you commit this. The patch pushed to master in commit: http://git.eclipse.org/c/buckminster/buckminster.git/commit/org.eclipse.buckminster.core/src?id=2c0cfe6f593389ea475ab5fae0f827444d88767d |
Created attachment 206630 [details] org.eclipse.buckminster.core-maven_source_jar.patch Mangling of source bundle jars retrieved from maven - governed by the "buckminster.convert.source" property - fails on Windows. A warning similar to the following one is displayed in the Buckminster console: Unable to rename C:\Install\Eclipse\Platform\plugins\hazelcast.source_1.9.4.jar to C:\Install\Eclipse\Platform\plugins\oldbundle-1717893016361118425.jar The problem is that Windows refuse to overwrite an existing file when performing File.renameTo(File). The attached trivial patch fixes the issue.