Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 363116

Summary: Push dialog has no cancel button
Product: [Technology] EGit Reporter: Sam Davis <sam.davis>
Component: UIAssignee: Project Inbox <egit.ui-inbox>
Status: RESOLVED WONTFIX QA Contact:
Severity: normal    
Priority: P3    
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
push dialog none

Description Sam Davis CLA 2011-11-07 21:06:11 EST 
The push dialog has no cancel button.
Comment 1 Kevin Sawicki CLA 2011-11-08 19:06:43 EST 
Where did you launch the dialog from?

I see a cancel button when selecting a repository from the Git Repositories view and selecting Push...
Comment 2 Sam Davis CLA 2011-11-08 19:20:47 EST 
Created attachment 206632 [details]
push dialog

I launched it from the Package Explorer. Here's a screenshot (you can ignore the error message).
Comment 3 Kevin Sawicki CLA 2011-11-08 19:25:08 EST 
That is the results dialog for the push operation, a "Cancel" button would be the exact same as if the "OK" button was selected
Comment 4 Sam Davis CLA 2011-11-08 19:41:50 EST 
I see. Maybe there should be some sort of confirmation dialog before the push happens?
Comment 5 Kevin Sawicki CLA 2011-11-08 19:53:18 EST 
The last page of the Push... action wizard shows confirmation of what will be pushed and has a Cancel button
Comment 6 Sam Davis CLA 2011-11-08 20:13:02 EST 
When I push from the package explorer, I get only the dialog shown above, no wizard.
Comment 7 Kevin Sawicki CLA 2011-11-08 20:15:48 EST 
Are you running Push to Upstream from the package explorer?
Comment 8 Sam Davis CLA 2011-11-08 23:12:28 EST 
I am.
Comment 9 Sam Davis CLA 2012-01-04 19:30:56 EST 
Marking as WONTFIX. Now that I understand EGit better, I think this is fine, it was just confusing at first.