Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 362932

Summary:	MenuManager of a view menu must not be disposed when the menu goes hidden
Product:	[Eclipse Project] Platform	Reporter:	Remy Suen <remy.suen>
Component:	UI	Assignee:	Remy Suen <remy.suen>
Status:	VERIFIED FIXED	QA Contact:	Paul Webster <pwebster>
Severity:	normal
Priority:	P3
Version:	4.2
Target Milestone:	4.2 M4
Hardware:	All
OS:	All
Whiteboard:

Description Remy Suen

2011-11-04 14:16:48 EDT

We have code that disposes the menu manager of a part's view menu when the menu goes hidden. This means all contribution items of that manager will be disposed as well. Some contribution items are written in such a way that after a dispose() they become useless. We should not dispose the menu manager of a part's menu.

Comment 1 Remy Suen

2011-11-07 09:20:45 EST

Fix pushed to master.
http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=71df4cb2a36bb2caa199afa0a29b8e8c7d36f3b4

Comment 2 Remy Suen

2011-12-08 09:14:31 EST

Verified with I20111208-0200 on Windows 7.