Bugzilla – Full Text Bug Listing
| Summary: | RWT reports incorrect content-type for images | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [RT] RAP | Reporter: | Cole Markham <cole> | ||||
| Component: | RWT | Assignee: | Project Inbox <rap-inbox> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P1 | CC: | ingo.meyer, ivan, klausste | ||||
| Version: | 1.5 | ||||||
| Target Milestone: | 2.0 M3 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Hi Cole, thanks for the patch, it looks good to me at first sight. But without unit tests, how can we know that you did not oversee some corner cases, e.g. when dealing with indexOf() etc.? Sorry for nagging, but we really need tests ;-) Could you include them in the patch? Hi, I had exactly the same problem, but just when using SSL and IE. Please see the full story here: http://www.eclipse.org/forums/index.php/t/369244/ The integration of the patch had saved me days of frustration, so I think this patch should be included. If Cole is not present here anymore, I will try to add some test in the next weeks. But I've never contributed to an eclipse project :-) Ralf, if I get some unit tests written for this, is it something we could get included into RAP 1.5 maintenance release or will it have to wait for 2.0? (In reply to comment #3) > Ralf, if I get some unit tests written for this, is it something we could get > included into RAP 1.5 maintenance release or will it have to wait for 2.0? I think this issue is severe enough to include it in RAP 1.5.2. Applied patch with some modifications with commit a86e839743d5f063b4f6b207d9027cef0d278a60. Added some new tests and fixed existing. For the record: Fixed the same issue with the custom cursors too. As Ralf mentioned before this bug should be fixed in 1.5.2! Is it fixed in 1.5.2? (In reply to comment #7) > As Ralf mentioned before this bug should be fixed in 1.5.2! > Is it fixed in 1.5.2? Unfortunately not. |
Created attachment 206473 [details] Patch to add file extensions to theme images and generated images in RWT We ran into a problem on some client systems running IE8 where images coming from RAP were not being displayed. I tracked it down to an incorrect content-type being sent by the server since the filenames generated by RWT do not have extensions. I cannot figure out the IE setting to reproduce the error locally, but the attached patch fixes the problem on the client machines. Both theme images and generated images needed to be changed.