| Summary: | [spell checking] New words for spelling check | ||
|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Lars Vogel <Lars.Vogel> |
| Component: | Text | Assignee: | Matthias Mailänder <matthias.mailaender> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | trivial | ||
| Priority: | P3 | CC: | andreidraga, bugs.eclipse.org, daniel_megert, elias, Lars.Vogel, matthias.mailaender, pbenedict, thatnitind, timo.kinnunen, wim.jongman |
| Version: | 3.8 | ||
| Target Milestone: | 4.4 M3 | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
|
Description
Lars Vogel
+Evangelist +handsets +programmatically +Apache +Acknowledgement +offline *** Bug 365782 has been marked as a duplicate of this bug. *** +idempotent +fingerprint +iff +committer + persistable + mime +Externalize +malformed + Euro + licensor + compliancy + (force) majeure + pursuance +Uncheck +uncheck +png +jpg +gif +apps @Dani: Any change that you bring these words in for Eclipse 4.2 / 3.8? I see no target milestone. (In reply to comment #18) > @Dani: Any change that you bring these words in for Eclipse 4.2 / 3.8? I see no > target milestone. Obviously things like "png" don't qualify, so I have to check each entry in this bug and currently I'm busy with much more important things. If it is important for you, then please check each entry against: For British English: http://www.macmillandictionary.com/dictionary/british For American English: http://www.merriam-webster.com/dictionary and provide a list of valid words or even better, a patch. +compliant @Dani: which plugin & file do I need to patch? (In reply to comment #21) > +compliant > > @Dani: which plugin & file do I need to patch? /org.eclipse.jdt.ui/dictionaries *** Bug 384721 has been marked as a duplicate of this bug. *** +buildable +reusable +Creational +orientated (In reply to comment #25) > +Creational > +orientated Ple(In reply to comment #25) > +Creational > +orientated Please see comment 20. > Please see comment 20.
The comment is not forgotten, I still collect words in this bug report as I notice them. At some point in the future I will to do the check and provide a patch.
+versioning +Lifecycle Once we have Gerrit for JDT UI, see Bug 414105, I plans to use this bug as a test case. +rectify +refactor +quad +colorspace +int +viewport +orthographic +uncomment +teleport +teapot +classpath Submitted a patch at https://git.eclipse.org/r/15830 with words proposed here (except abbreviations) checked against http://dict.leo.org/ (In reply to comment #33) > Submitted a patch at https://git.eclipse.org/r/15830 with words proposed > here (except abbreviations) checked against http://dict.leo.org/ Please see bug 362888 comment 20. In the process of going over the words I found more words that are not recognized by the spell-checker. I have included them below as well. Acknowledgment = the act of acknowledging / something that you say or do in order to show that you accept that something exists or is true Apache = a member of a group of American Indian peoples of the southwestern United States / no British definition southwestern = lying toward or coming from the southwest / in or from the south-west of a country or region southwest = to, toward, or in the southwest / the direction that is between south and west. The south-west is the part of a country that is in this direction. Euro = the common basic monetary unit of most countries of the European Union / the unit of money that is used in most countries in the European Union. Its symbol is €. buildable = suitable for building; especially : capable of being built / a machine, vehicle, or other structure that is made by putting its parts together (derived from build (transitive)) committer = a person from whom a charge or trust is committed (derived from committee) / someone who gives someone or something to someone else to look after (derived from commit (formal)) compliancy = compliance / no British definition creational = N/A / done or used for creating something (derived from recreational, recreation and creation) evangelist = N/A / a member of an evangelical church evangelical = N/A / relating to a form of Christianity in which church services are very lively and people express their religious beliefs in an open and enthusiastic way Christianity = N/A / the religion based on the ideas of Jesus Christ. Its followers worship in a church. Jesus Christ = N/A / the man on whose ideas Christianity is based. Christians believe he was the son of God. He is often simply called Jesus or Christ. fingerprint = N/A / a mark that you leave on something when you touch it, showing the pattern of lines on the skin of your fingers handsets, handset = N/A / the part of a telephone that you hold next to your ear idempotent = relating to or being a mathematical quantity which when applied to itself under a given binary operation (as multiplication) equals itself / no British definition iff = N/A / a word used in mathematics and logic meaning 'if and only if' int = N/A / internal licensor = licenser / no British definition (force) majeure = N/A / an unexpected event that stops you doing something that you promised to do in a contract malformed = N/A / badly formed or shaped mime = N/A / to tell a story or express yourself without words, using only the movements of your body and face offline = N/A / not directly connected to a computer orientated = N/A / oriented, mainly concerned with, or directed towards, a particular group, activity, or situation persistable = N/A / being able to continue to do or say something in a determined way (derived from persist) programmatically = N/A / happening or done according to a plan (derived from programmatic, as an adverb) pursuance = N/A / in order to achieve an aim quad = N/A / a quadruplet quadruplet = N/A / a baby who is born at the same time as three other babies to the same mother rectify = N/A / to correct a problem or mistake, or to make a bad situation better refactor = N/A / to factorize a number again (derived from factor (verb)) factorize = to divide a number exactly into smaller numbers that can be multiplied together to make the original number teapot = N/A / a container with a handle and a spout (=small tube for pouring), used for making and pouring tea teleport = N/A / to send people and objects very quickly from one place to another in the form of energy or signals. Some people believe this may be possible in the future. throwable = N/A / a game or competition that can be deliberately lost (derived from throw, as an adjective) uncheck = N/A / to no longer stop yourself or someone else from doing something (derived from check (transitive)) versioning = N/A / creating a form of something that is different from other forms or from the original (derived from version, mention and mentioning) externalize = to make external or externally manifest / to express feelings and thoughts orthographic = of, relating to, being, or prepared by orthographic projection / no British definition These don't have a general dictionary definition, but they are defined within the broad field of computer sciences: viewport = refers to one specific piece in a system related to 3D computer graphics. uncomment = performing a specific programming language source code change in a text editor. classpath = the name of a Java-specific programming environment feature. These are alternate versions: colorspace = color space lifecycle = life cycle @Time, Dani defined the criteria for inclusion in Comment 20 and AFAIK this is not open for discussion. I personally also agree with the approach of using official dictionaries. This helps to avoid lengthy discussions about if a word should be included or not. @Matthias, I suggest you check the words we collected so gar against the online dictionaries and report "invalid" words in this bug after updating the review. Lars, what I listed was the definition found by checking each word ('entry') against merriam-webster.com and macmillandictionary.com dictionaries, respectively. M-W was behind a paywall for most of the time; those were marked N/A. If 'valid word' is taken to mean a word that someone who understands English but isn't familiar with that word can find a definition for using one of the dictionaries, then the 1st list in comment 35 is a list of such words and their definitions.
However, that would still leave the spell checker marking the word "classpath" - used in several places within the Eclipse IDE itself - as spelled wrong. Maybe a new bug should be opened for that one?
Timo, I re-checked "committer" in both directories and they returned that this word is unknown. What did you do different? I did what someone who is using a dictionary to check the meaning of a word would do if the dictionary didn't have that particular variation of it: I didn't give up but looked at the similar words that were suggested. I'll retrace my steps: Merriam-Websters: the word committee is suggested in a dropdown list when you type in the word committer. The first definition for the word committee is "archaic : a person to whom a charge or trust is committed". Employee is to employer as committee is to committer, ergo committer is a person from whom a charge or trust is committed. Macmillan: the word committed is the first suggestion in the "Did you mean" list when you search for committer. The definition page for committed contains a "related dictionary definitions" section with a link to "commit, verb". One of the definitions of commit is "to give someone or something to someone else to look after". A writer is someone who writes, ergo a committer is someone who gives someone or something to someone else to look after. It's remarkable how close to the correct definition both of those are despite coming from different dictionaries that are in no way geared towards IT terminology. I guess it empirically proves that this manner of checking a word is proper and valid. (In reply to comment #39) > I did what someone who is using a dictionary to check the meaning of a word > would do if the dictionary didn't have that particular variation of it: I > didn't give up but looked at the similar words that were suggested. @Dani, is this in line with your acceptance criteria? (In reply to comment #40) > (In reply to comment #39) > > I did what someone who is using a dictionary to check the meaning of a word > > would do if the dictionary didn't have that particular variation of it: I > > didn't give up but looked at the similar words that were suggested. > > @Dani, is this in line with your acceptance criteria? If the argumentation would be correct, then the word would be in the dictionary ;-). I want to keep a clear rules. I don't know what criteria the maintainers of dictionaries use to decide which word forms to add and when, but I know me having to workaround few missing derivative words is not the deciding factor. Oxford English Dictionary at oxforddictionaries.com recognizes the word *committer* as a noun derivative from the verb commit so it seems there are no generalizations to be drawn here. The difference could be just in a conscious decision to make your dictionary that much more easy to use and then doing it. Of the word *versioning*, Oxford's American-English definition says: " version verb [with object] (often as noun versioning) create a new version of: it’s the software for you if you need versioning and group editing" Now that's how one exceeds expectations and goes to set the example for others to strive for. Getting back to https://git.eclipse.org/r/15830 I simply check the words I added against those well known dictionary publisher instead of http://dict.leo.org/ (a project run by the Technical University of Munich, Computer Science Department that is very popular in Germany) to get merged? @Matthias, yes. I suggest you create a little spreadsheet (maybe an Google doc which can be later exported as .cvs file and attached to this bug) which contain your checks. As format I suggest: Word Macmillandictionary Merriam-webster comment screenshot Yes Yes screenshots Yes Yes Evangelist Yes Yes handsets No No handset Yes Yes added because handsets failed etc. After we have the data, you can update your Gerrit review patch. And once we have done this work, Dani could apply the patch (if he trusts us) or check the words again (if we does not) ;-) Here we go https://docs.google.com/spreadsheet/pub?key=0ApPX-BsqgwegdEtSX1JLc0lDQ1B2Q1I2Y2hfbHFmZnc&output=html I used only dictionaries by reliable well-known publishers except Merriam Webster because for the 14 days trial triggered after several searches they want your credit card number. @Matthias, could you add the links for Apache? It looks to me that it is contained in the official dictionaries? @Dani, are you ok with a Gerrit review for the green entries in the spreadsheet? (In reply to Matthias Mailänder from comment #45) > Merriam Webster because for the 14 > days trial triggered after several searches they want your credit card > number. I've never seen this in years. (In reply to Lars Vogel from comment #46) > @Dani, are you ok with a Gerrit review for the green entries in the > spreadsheet? Yes, if they follow the rules ;-). > I've never seen this in years. Maybe you never checked a lot of words in the same session. > Yes, if they follow the rules ;-). The rules seems to require a credit card, which I hope invalidates that rule. Are you ok with http://dictionary.cambridge.org/dictionary/british/ as new checker? (In reply to Lars Vogel from comment #49) > > I've never seen this in years. > > Maybe you never checked a lot of words in the same session. Possibly, but for earlier requests I used in several times in a row without problems. Maybe they changed it in the meantime. > > Yes, if they follow the rules ;-). > > The rules seems to require a credit card, which I hope invalidates that > rule. Are you ok with http://dictionary.cambridge.org/dictionary/british/ > as new checker? Sounds wrong, given we use Merriam Webster for AMERICAN English. I don't have time to evaluate a new dictionary at this point. If you are confident with the words, you can prepare a patch and I will sanity check some of the entries. If they pass, I'll accept the change. > Sounds wrong, given we use Merriam Webster for AMERICAN English. I don't > have time to evaluate a new dictionary at this point. oxforddictionaries.com has also English: http://oxforddictionaries.com/definition/american_english/ > If you are confident with the words, you can prepare a patch @Matthias, sounds good. Please create a Gerrit review for Dani. (In reply to Matthias Mailänder from comment #52) > See https://git.eclipse.org/r/#/c/17076/ Thanks. The change is almost good. See my comments there. I updated https://git.eclipse.org/r/#/c/17076/ Sorry for the change commit spam. I am just getting used to EGit and Gerrit. Submitted with http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=663e87e2e5920bb984560072ed5c7dc12401c8f6 Thanks Dani and Matthias! +proxies (In reply to Paul Benedict from comment #57) > +proxies This bug here is closed, so adding new words here won't help. Dani, is this the only ticket that's ever going to add dictionary words for 4.4? My opinion is to keep this ticket open until RC1 so other words can be added. (In reply to Paul Benedict from comment #59) > Dani, is this the only ticket that's ever going to add dictionary words for > 4.4? My opinion is to keep this ticket open until RC1 so other words can be > added. We can collect more words in a new bug. Once a patch is ready and released, I want the bug to be closed. That's easier to track. |