Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 362849

Summary:	AssertionFailedException in RetargetBreakpointAction
Product:	[Eclipse Project] Platform	Reporter:	Pawel Piech <pawel.1.piech>
Component:	Debug	Assignee:	Pawel Piech <pawel.1.piech>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	Michael_Rennie, remy.suen
Version:	3.7.1	Flags:	Michael_Rennie: review+
Target Milestone:	3.8 M4
Hardware:	PC
OS:	Linux
Whiteboard:

Description Pawel Piech

2011-11-03 18:32:18 EDT

In a Wind River product based on platform 3.7.1 we encountered the following exception:

We've encountered the following exception.  I believe the problem is local to RetargetBreakpointAction, where it tries to update its enablement with getActivePart() == null.  


org.eclipse.core.runtime.AssertionFailedException: null argument:

	at org.eclipse.core.runtime.Assert.isNotNull(Assert.java:85)

	at org.eclipse.core.runtime.Assert.isNotNull(Assert.java:73)

	at org.eclipse.core.expressions.EvaluationContext.<init>(EvaluationContext.java:46)

	at org.eclipse.debug.internal.ui.DebugUIPlugin.createEvaluationContext(DebugUIPlugin.java:1323)

	at org.eclipse.debug.internal.ui.actions.ToggleBreakpointsTargetManager$ToggleTargetFactory.evalEnablementExpression(ToggleBreakpointsTargetManager.java:162)

	at org.eclipse.debug.internal.ui.actions.ToggleBreakpointsTargetManager$ToggleTargetFactory.isEnabled(ToggleBreakpointsTargetManager.java:129)

	at org.eclipse.debug.internal.ui.actions.ToggleBreakpointsTargetManager.getEnabledFactories(ToggleBreakpointsTargetManager.java:485)

	at org.eclipse.debug.internal.ui.actions.ToggleBreakpointsTargetManager.getPreferredToggleBreakpointsTargetID(ToggleBreakpointsTargetManager.java:540)

	at org.eclipse.debug.internal.ui.actions.ToggleBreakpointsTargetManager.getToggleBreakpointsTarget(ToggleBreakpointsTargetManager.java:554)

	at org.eclipse.debug.internal.ui.actions.breakpoints.RetargetBreakpointAction.getAdapter(RetargetBreakpointAction.java:44)

	at org.eclipse.debug.internal.ui.actions.RetargetAction.selectionChanged(RetargetAction.java:146)

	at org.eclipse.debug.internal.ui.actions.breakpoints.RetargetBreakpointAction.selectionChanged(RetargetBreakpointAction.java:64)

	at org.eclipse.ui.internal.PluginAction.refreshEnablement(PluginAction.java:206)

	at org.eclipse.ui.internal.PluginAction.selectionChanged(PluginAction.java:277)

	at org.eclipse.ui.internal.PluginAction.selectionChanged(PluginAction.java:299)

	at org.eclipse.ui.internal.AbstractSelectionService.fireSelection(AbstractSelectionService.java:156)

	at org.eclipse.ui.internal.AbstractSelectionService.setActivePart(AbstractSelectionService.java:282)

	at org.eclipse.ui.internal.WWinPartService.updateActivePart(WWinPartService.java:135)

	at org.eclipse.ui.internal.WWinPartService.access$0(WWinPartService.java:125)

	at org.eclipse.ui.internal.WWinPartService$WWinListener.partDeactivated(WWinPartService.java:50)

	at org.eclipse.ui.internal.PartListenerList2$4.run(PartListenerList2.java:115)

	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)

	at org.eclipse.core.runtime.Platform.run(Platform.java:888)

	at org.eclipse.ui.internal.PartListenerList2.fireEvent(PartListenerList2.java:55)

	at org.eclipse.ui.internal.PartListenerList2.firePartDeactivated(PartListenerList2.java:113)

	at org.eclipse.ui.internal.PartService.firePartDeactivated(PartService.java:242)

	at org.eclipse.ui.internal.PartService.setActivePart(PartService.java:300)

Comment 1 Pawel Piech

2011-11-03 18:41:23 EDT

I committed a simple fix: http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=10d115a56d8e361de6cc36e3f46f6bf841c1e35b

Mike please review.

Comment 2 Remy Suen

2011-11-04 06:26:52 EDT

(In reply to comment #1)
> I committed a simple fix:
> http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=10d115a56d8e361de6cc36e3f46f6bf841c1e35b

Looks like this commit broke the nightly build. Pawel, could you take a look?
http://dev.eclipse.org/mhonarc/lists/platform-releng-dev/msg19270.html

Comment 3 Remy Suen

2011-11-04 07:34:21 EDT

(In reply to comment #2)
> (In reply to comment #1)
> > I committed a simple fix:
> > http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=10d115a56d8e361de6cc36e3f46f6bf841c1e35b
> 
> Looks like this commit broke the nightly build. Pawel, could you take a look?
> http://dev.eclipse.org/mhonarc/lists/platform-releng-dev/msg19270.html

Dani fixed the problem it seems.
http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=dd2b4bb2a2daa84d458ab3975b9157d4771584fb

Comment 4 Michael Rennie

2011-11-04 09:22:29 EDT

+1 the fixed fix makes sense :)