Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 362843

Summary: [Compare]Revisit compare editor widget.
Product: [ECD] Orion Reporter: libing wang <libingw>
Component: ClientAssignee: libing wang <libingw>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: eclipse.felipe, Silenio_Quarti, susan
Version: 0.3   
Target Milestone: 0.5   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description libing wang CLA 2011-11-03 16:47:36 EDT 
Today I talked to Silenio and Felipe about optimizing the compare widget to follow up with the Editor's recent changes.There are several things we need to do in 0.4.
1.Remove all the rulers, use annotation model.
2.Use projection model instead of "extending" text model, for both inline and side-by-side widget.

Also, for the incoming usage from the search&replace preview, we need to change the way that the compare widget is parsing a unified diff.

3.It does not have to always handle a unified diff. Some times the widget consumer just need to provide two pieces of in-memory content with diff mapper.
4.Lighter weight content on each side of the compare widget. Prev/next diff only render the surrounding content(e.g. 5 line before and after the diff line. This might reduce the performance issue for previewing long files.
Comment 1 libing wang CLA 2011-11-22 17:49:33 EST 
Another topis is a better way to hook up syntax highlighting(e.g.  particularly for c#, cpp, vb, and f#.)
Comment 2 libing wang CLA 2012-02-17 09:29:38 EST 
As mentioned in bug 371601, we should replace the inline compare model to the projection model as well.
The inline text model was designed to have the dummy text where the diff is presented. At the moment the projection model was not there yet.
Comment 3 libing wang CLA 2012-05-22 09:43:38 EDT 
(In reply to comment #2)
> As mentioned in bug 371601, we should replace the inline compare model to the
> projection model as well.
> The inline text model was designed to have the dummy text where the diff is
> presented. At the moment the projection model was not there yet.

The last item : the inline compare model is replaced by tge tru model, closing it now.