Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 362813

Summary: ModelElement's copy method doesn't handle Derived properties
Product: z_Archived Reporter: Shenxue Zhou <shenxue.zhou>
Component: SapphireAssignee: Konstantin Komissarchik <konstantin>
Status: CLOSED FIXED QA Contact:
Severity: major    
Priority: P3    
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:

Description Shenxue Zhou CLA 2011-11-03 11:56:41 EDT
When a model element contains derived properties, calling it's copy() method would result in the illegal argument exception. Here is a sample of the stack trace:

java.lang.IllegalArgumentException: Cannot write property Breakpoint.
	at org.eclipse.sapphire.modeling.ModelElement.write(ModelElement.java:405)
	at oracle.eclipse.tools.adf.controller.model.internal.MethodCall.write(MethodCall.java:858)
	at org.eclipse.sapphire.modeling.ModelElement.copy(ModelElement.java:502)
	at org.eclipse.sapphire.modeling.ModelElement.copy(ModelElement.java:535)
	at oracle.eclipse.tools.adf.controller.operations.internal.CreateTaskFlowTemplateOpMethods.execute(CreateTaskFlowTemplateOpMethods.java:85)
	at oracle.eclipse.tools.adf.controller.operations.internal.CreateTaskFlowTemplateOp.execute(CreateTaskFlowTemplateOp.java:294)
	at org.eclipse.sapphire.ui.swt.SapphireWizard.performFinish(SapphireWizard.java:143)
	at org.eclipse.sapphire.ui.swt.SapphireWizard$2.run(SapphireWizard.java:107)
	at org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:121)

I think derived properties don't need to be copied.
Comment 1 Konstantin Komissarchik CLA 2011-11-04 10:48:48 EDT
Fixed. Please verify.
Comment 2 Shenxue Zhou CLA 2011-11-04 12:14:26 EDT
Verified the fix. Closing.