Bugzilla – Full Text Bug Listing
| Summary: | webEditingPlugin using editor code | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Mark Macdonald <mamacdon> |
| Component: | Editor | Assignee: | Project Inbox <orion.editor-inbox> |
| Status: | RESOLVED WONTFIX | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | bokowski, eclipse.felipe, simon_kaegi, susan |
| Version: | 0.3 | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Whiteboard: | |||
|
Description
Mark Macdonald
Right now core components depend on the editor. Editor does not depend on core (except by a few examples, but that could be modified). So I would say that having webEditingPlugin inside core and reaching in the editor is better than the other way around. It is funny that the editor bundle is more "core" than the core bundle. But that is due to the way the core bundle is organized. It would look better if the core was divided so that core only really includes the core bits (like requirejs, services, registry, etc) without any dependencies. The rest of the stuff that is there should be moved to a ui bundle or similar. Thought ? (In reply to comment #1) > It would look better if > the core was divided so that core only really includes the core bits (like > requirejs, services, registry, etc) without any dependencies. The rest of the > stuff that is there should be moved to a ui bundle or similar. There is similar discussion in bug 361487 I don't think the shape of what goes into which OSGi bundle is all that important at this stage. People consuming our scripts are just going to copy them from whatever directory we put them in, and they will assemble them together in perhaps a completely different shape. Neither of the OSGi bundles (core, editor, git) have any dependency on each other because OSGi doesn't capture JS dependencies. So basically what we are discussing is should the script go in one directory or another... Anyway, in the end we probably do want to put the scripts used by plugins separate from the "core" scripts that aren't coming from plugins. That's what I was starting to do with webEditingPlugin by creating a separate directory for its scripts. I don't really care which OSGi bundle we put those scripts in but I do think the scripts used by a given plugin should be packaged together. *** Bug 349703 has been marked as a duplicate of this bug. *** Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see: https://dev.eclipse.org/mhonarc/lists/orion-dev/msg03444.html Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see: https://dev.eclipse.org/mhonarc/lists/orion-dev/msg03444.html |