Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 362655

Summary:	SimpleNamesFragment incorrect/not updated
Product:	[Modeling] TMF	Reporter:	Meinte Boersma <meinte.boersma>
Component:	Xtext	Assignee:	Project Inbox <tmf.xtext-inbox>
Status:	CLOSED FIXED	QA Contact:
Severity:	major
Priority:	P3	CC:	karsten.thoms, knut.wannheden, sven.efftinge, tg, tokraemercli
Version:	unspecified	Flags:	sven.efftinge: juno+
Target Milestone:	M4
Hardware:	Macintosh
OS:	Mac OS X - Carbon (unsup.)
Whiteboard:

Description Meinte Boersma

2011-11-02 07:32:22 EDT

Build Identifier: M20110909-1335

The SimpleNamesFragment binds org.eclipse.xtext.ui.refactoring.IDependentElementsCalculator to org.eclipse.xtext.ui.refactoring.IDependentElementsCalculator.Null, but the latter one doesn't exist anymore. In fact, the default implementation (through Guice annotations) is DefaultDependentElementsCalculator, so the explicit binding could be left out. If left in, the binding target should be DefaultDependentElementsCalculator, just as the QualifiedNamesFragment does.

(You guys should really have some test case with the SimpleNamesFragment - not everyone only builds JVM languages with fully qualified names ;))

Reproducible: Always

Steps to Reproduce:
1. see details
2.
3.

Comment 1 Sebastian Zarnekow

2011-11-07 04:46:42 EST

*** Bug 363022 has been marked as a duplicate of this bug. ***

Comment 2 Sven Efftinge

2011-11-07 15:00:32 EST

pushed to master

Comment 3 Sebastian Zarnekow

2011-11-08 09:57:21 EST

*** Bug 363179 has been marked as a duplicate of this bug. ***

Comment 4 Karsten Thoms

2017-09-19 17:02:41 EDT

Closing all bugs that were set to RESOLVED before Neon.0

Comment 5 Karsten Thoms

2017-09-19 17:14:11 EDT

Closing all bugs that were set to RESOLVED before Neon.0