Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 362602

Summary:	[target] Target persistence for contributed locations is incorrect
Product:	[Eclipse Project] PDE	Reporter:	Curtis Windatt <curtis.windatt.public>
Component:	UI	Assignee:	Curtis Windatt <curtis.windatt.public>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	ankur_sharma, Michael_Rennie
Version:	3.7
Target Milestone:	3.8 M4
Hardware:	PC
OS:	Linux
Whiteboard:

Description Curtis Windatt

2011-11-01 17:11:28 EDT

This is part of the reason why the IUBundleContainer tests were failing.  Mike has pushed a fix for the tests:

http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=9c193fac08191401da2500c16db91a6c786d5213

The client should not be responsible for the location element.  They should only be contributing xml to place inside the location element which we create.  Furthermore, the returned xml string should not have another xml header (version/encoding).

The API doesn't give any details about what the xml string must contain, so the current implementation would be difficult or impossible for clients to use correctly.

Comment 1 Curtis Windatt

2011-11-03 12:39:19 EDT

Fixed in master

http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=00c5ad91e800dae59a6380dba24e98dba8959052

The API makes it clear that the client must return an xml string that does not contain any header and a single root element named location. We validate the xml before including the location in the target.

I tried having the clients only contribute content inside of the location element, but this ended up being a lot of work parsing/creating xml elements for no significant gain.  What we really need here is the IMemento framework, but that is only available in UI.

Comment 2 Curtis Windatt

2011-12-06 17:44:12 EST

Tested the target platform heavily during today's milestone test pass.  Things
appear to be working well.  Verified in I20111206-1015