Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 362571

Summary:	Please make submodules of org.eclipse.jetty.toolchain provide separate source tarballs
Product:	[RT] Jetty	Reporter:	Stanislav Ochotnicky <sochotnicky>
Component:	other	Assignee:	Jesse McConnell <jesse.mcconnell>
Status:	RESOLVED MOVED	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	akurtakov, joakim.erdfelt
Version:	unspecified
Target Milestone:	7.5.x
Hardware:	All
OS:	All
Whiteboard:

Description Stanislav Ochotnicky

2011-11-01 10:44:00 EDT

Build Identifier: 

I know these can be accessed from web git.eclipse.org/c/jetty/org.eclipse.jetty.toolchain.git/ but gitweb produces tarballs for whole tree, not just submodule.

It's not a big deal. I am glad you even produce source tarballs, which is important for Linux distributions. That said I'd love to be able to have per-module tarballs. I can see two ways to do it:
 1. Somehow modify github to understand maven modules + tags (Not sure how that'd work)
 2. Start producing tarballs per module (using maven-assembly-plugin with "project" descriptorRef usually works great)

I must say both current jetty git and jetty-toolchain git repos are one of the nicest big Maven things I've seen from Linux packager POV. You improved this a lot recently so thanks and keep up the good work!

Reproducible: Always

Comment 1 Jesse McConnell

2011-11-01 11:42:22 EDT

ok, so your issue here is that your pulling down the tag of say, the jetty-versions-maven-plugin-1.0.7 and it is really a tag of the whole repo...

fwiw the subdirectory for the plugin is the actual tagged version so if you just descend into that directory you should be able to build what you need there, would that work?

Comment 2 Stanislav Ochotnicky

2011-11-01 12:03:59 EDT

Yes I am aware of this. Of course git tags cannot represent part of tree because they are by design repository-wide, that's why I said we'd have to teach gitweb to understand maven projects (and modules). Even then it would be impossible to match a tag to a submodule unless there was a standardized naming of tags.

So yes, as long as there are no per-module source tarballs I'll be using global tarball and descending into proper subdirectory to build. If you don't plan to generate separate source tarball for each module that has its own release cycle I am OK as long as each release is tagged (it will just mean we'll be keeping more stuff on our build servers/srpms basically). If you don't want to generate (I know it would involve some work on each release), no problem. Just wanted to be sure you are aware of this.

Comment 3 Jesse McConnell

2011-11-01 12:36:20 EDT

ok, so yes, I am aware of it (now) and how this could be problematic for you guys to maintain.

lemme give it a bit of thought and I suspect I'll take care of this for you, just give me a bit to get some time to make it happen.

cheers,
jesse

Comment 4 Stanislav Ochotnicky

2011-11-01 12:55:59 EDT

I marked this as enhancement for a reason. There are already tarballs we can use and so even if you decide to fix this, it's not a priority. Thanks for looking into it. I want to strike a balance where I don't sacrifice your convenience for our standardization of builds.

Comment 5 Joakim Erdfelt

2016-02-17 10:24:07 EST

Project moved to https://github.com/eclipse/jetty.toolchain