Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 362496

Summary:	[quick assist][nls tooling] IAE in new 'Create field...' quick assist in properties editor
Product:	[Eclipse Project] JDT	Reporter:	Deepak Azad <deepakazad>
Component:	Text	Assignee:	Deepak Azad <deepakazad>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	deepakazad, raksha.vasisht
Version:	3.8
Target Milestone:	3.8 M4
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Deepak Azad

2011-10-31 10:48:00 EDT

If a property is not a valid java identifier the following exception is thrown on invoking the quick assist. 

java.lang.IllegalArgumentException
	at org.eclipse.jdt.core.dom.SimpleName.setIdentifier(SimpleName.java:198)
	at org.eclipse.jdt.core.dom.AST.newSimpleName(AST.java:2031)
	at org.eclipse.jdt.internal.corext.refactoring.nls.AccessorClassModifier.getNewFinalStringFieldDeclaration(AccessorClassModifier.java:331)
	at org.eclipse.jdt.internal.corext.refactoring.nls.AccessorClassModifier.addKey(AccessorClassModifier.java:291)
	at org.eclipse.jdt.internal.corext.refactoring.nls.AccessorClassModifier.addKey(AccessorClassModifier.java:282)
	at org.eclipse.jdt.internal.corext.refactoring.nls.AccessorClassModifier.addFields(AccessorClassModifier.java:191)
	at org.eclipse.jdt.internal.ui.propertiesfileeditor.PropertiesQuickAssistProcessor.getCreateFieldsInAccessorClassProposals(PropertiesQuickAssistProcessor.java:188)
	at org.eclipse.jdt.internal.ui.propertiesfileeditor.PropertiesQuickAssistProcessor.collectAssists(PropertiesQuickAssistProcessor.java:87)
	at org.eclipse.jdt.internal.ui.propertiesfileeditor.PropertiesCorrectionProcessor.computeQuickAssistProposals(PropertiesCorrectionProcessor.java:8

Comment 1 Deepak Azad

2011-10-31 10:53:07 EDT

Fixed in master - 02dab19d88de7da80ad7430db6057ec8f7d3e5f1

Now the quick assist simply ignores such properties.

Comment 2 Raksha Vasisht

2011-12-06 06:50:51 EST

Verified for Juno M4 with 4.2 I20111205-1810.