Bugzilla – Full Text Bug Listing
| Summary: | The JS code has syntax errors in external browser after closing the VE | ||||||
|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | fahua jin <jinfahua> | ||||
| Component: | EDT | Assignee: | Tony Chen <chenzhh> | ||||
| Status: | CLOSED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P1 | CC: | chenzhh, hjiyong, huozz, svihovec | ||||
| Version: | unspecified | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Created attachment 206193 [details]
The sample project.
Tony said he would take a look at the defect. Dojobase.js overrides egl.handleIDEEvent() method in egl_development.js, so some fixes in egl.handleIDEEvent() did not work when there's dojo widgets in the page.
After reviewing the overrided method in Dojobase.js, the only change is to increase the IDEEvent delay from 10ms to 1000ms.
egl_development.js: window.setTimeout("if (window.egl) egl.handleIDEEvent()", 10);
dojobase.js: window.setTimeout("if (window.egl) egl.handleIDEEvent()", 1000);
I discussed with Yunfeng & Jiyong and nobody thinks this is necessary. I'll just delete the override function. We will have some regression testing soon, if there's a problem, it should be revealed in the regression.
Looking over CVS history (KAN-SAV), I found that this code was originally added for RTC Defect 21846. I cannot say if this change was directly related to the fix, or if it was committed at the same time under this defect. The fix went into version 0.7.1 of the dojo widgets project. We should review the content of 21846 to verify why this change may have been added. I reopen the defect for the comment 4, and please resolve the defect after investigation. Thanks. After reviewing workitem 21846 and the cvs history of dojobase.js & egl_development.js. It turned out that both of them have 1000ms interval in year 2009, and in Jun 2010, egl_development.js changed the interval to 10ms for performance enhancement workitem 48064. So there's actually nothing special Dojobase.js is doing, it copied the same code from egl_development.js. But the later changes in egl_development.js does not get into Dojobase.js. I think its safe to remove that piece of code in Dojobase.js. Will close this bug. If anybody has a concern, please reopen. Close the defect. |
Build Identifier: 0.7.0.v201110302101 1) Open the MortgageCalculatorHandler.egl with VE. 2) Click the 'Preview' tab, and click the 'Show in external browser' button. 3) After displaying the handler in the external browser, switch back to the EDT. 4) Close the VE, and switch back to the browser. You'll find the browser keeps sending out the request, and displays following error message. Do we need to continuously send the request to the server even after the address is not avail? [CRRUI2092E] 内部错误：处理 IDE 事件 context terminated 时发生问题 eval("context terminated") :0 ("context terminated") DojoBase.js?contextKey=42:63 runHandler() egl_development.js:185 ([object Event]) egl_development.js:195 missing ; before statement Reproducible: Always