Bugzilla – Full Text Bug Listing
| Summary: | "Skip All Breakpoints" always appears on the main toolbar per default in Java perspective | ||
|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Andrey Loskutov <loskutov> |
| Component: | Debug | Assignee: | JDT-Debug-Inbox <jdt-debug-inbox> |
| Status: | CLOSED WONTFIX | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | daniel_megert, deepakazad, pawel.1.piech, remy.suen |
| Version: | 3.8 | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Whiteboard: | stalebug | ||
|
Description
Andrey Loskutov
Don't know about others but I often want to toggle 'Skip All Breakpoints' right before I start debugging, and this is one of the actions that I always want in the global toolbar. My point is, that if every Java related view would add it's buttons to the global toolbar, it will became overloaded. I see the point with the "start debugging" with no breakpoints, but in this case you will always have the breakpoints view somewhere as you expect to change something there. Considering this as a 5% use case, I guess it does not disturb the 75% use case where users simply code Java. As a compromise I would suggest to remove "Java element creation" buttons from the toolbar (I've NEVER EVER used it in over 9 years with Eclipse) and move the (initially hidden) "Skip All Breakpoints" *after* "Debug" group, as it logically belongs to it. You could then show it as soon as user starts debug session and let it visible then. (In reply to comment #1) > Don't know about others but I often want to toggle 'Skip All Breakpoints' right > before I start debugging, and this is one of the actions that I always want in > the global toolbar. That's also one reason for me but more important is that I see the current state of the breakpoints while the debug target is running and I'm coding in the Java perspective. > My point is, that if every Java related view would add it's buttons to the > global toolbar, it will became overloaded. Yes, I agree. Only those applicable/usable for more than one view should go there. I guess you know that you can remove the action from the toolbar if you don't like it (unless you are on 4.x and run into bug 320478). (In reply to comment #2) Having this button appear before debugging starts was not my intention. We could move this button to the Debug action set along with the run control actions. This way the button would appear only when debugging starts. The cost would be a little bit confusing organization of actions in Customize perspective dialog. Would this be a good compromise? (In reply to comment #4) > (In reply to comment #2) > > Having this button appear before debugging starts was not my intention. We > could move this button to the Debug action set along with the run control > actions. This way the button would appear only when debugging starts. The > cost would be a little bit confusing organization of actions in Customize > perspective dialog. > > Would this be a good compromise? Yes, thanks. (In reply to comment #4) > (In reply to comment #2) > > Having this button appear before debugging starts was not my intention. We > could move this button to the Debug action set along with the run control > actions. This way the button would appear only when debugging starts. -1. This makes the toolbar noisy, shifting things around when I start/stop debugging. Then I prefer to remove it by default and let the user bring it back. (In reply to comment #6) > (In reply to comment #4) > > (In reply to comment #2) > > > > Having this button appear before debugging starts was not my intention. We > > could move this button to the Debug action set along with the run control > > actions. This way the button would appear only when debugging starts. > -1. This makes the toolbar noisy, shifting things around when I start/stop > debugging. Then I prefer to remove it by default and let the user bring it > back. I'm not sure if I expressed myself well, so let me clarify. The debug toolbar is on by default only in Debug perspective. Also by default the perspective changes to Debug when debugging starts, so the "shifting" would only occur as part of the perspective changes as it does now. The debug toolbar is also linked to the Debug view, so if the perspective switch is disabled, the debug action set would be added to the Java perspective, but this would also happen along with the rest of the run control actions. So in essence, with the default settings left as they are, the only difference from current behavior would be that the button would not be visible in the Java perspective. Another downside though is that if Deepak wanted to make the skip-all button visible in Java perspective per his custom preference. He'd need to turn on the whole Debug action set, and perhaps hide the rest of run control buttons. But that's the compromise. (In reply to comment #7) > So in essence, with the default settings left as they are, the only difference > from current behavior would be that the button would not be visible in the Java > perspective. -1. Having the button in the Java perspective and when debugging is not started is my most important usecase for having the debug toolbar. To be honest, in my opinion 'Skip all breakpoints' is the 'only truly global' debug action as it does not depend on what is selected like the run actions - 'Run', 'Step over' etc. Disabling 'Skip all breakpoints' by default makes no sense to me. > Another downside though is that if Deepak wanted to make the skip-all button > visible in Java perspective per his custom preference. Alas, I cannot set a custom preference as I use 4.2 and bug 320478 prevents me from customizing perspectives :) > > Another downside though is that if Deepak wanted to make the skip-all button > > visible in Java perspective per his custom preference. > Alas, I cannot set a custom preference as I use 4.2 and bug 320478 prevents me > from customizing perspectives :) This just needs to get fixed and must not influence how we deal with this bug. > I'm not sure if I expressed myself well, so let me clarify. The debug toolbar > is on by default only in Debug perspective. Also by default the perspective > changes to Debug when debugging starts, so the "shifting" would only occur as > part of the perspective changes as it does now. Currently there is no shifting for me since I use different workbench windows for each perspective. > The debug toolbar is also > linked to the Debug view, so if the perspective switch is disabled, the debug > action set would be added to the Java perspective, but this would also happen > along with the rest of the run control actions. -1 for this as well. This would add even more clutter to the Java perspective. For now I would leave things as as they are until we get more feedback. Those who don't like it can remove the action in 3.8 and also in 4.2 once that bug is fixed. (In reply to comment #9) > For now I would leave things as as they are until we get more feedback. Those > who don't like it can remove the action in 3.8 and also in 4.2 once that bug is > fixed. +1 This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug. If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie. |