Bugzilla – Full Text Bug Listing
| Summary: | Screen space waste | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Andrey Loskutov <loskutov> |
| Component: | UI | Assignee: | Platform UI Triaged <platform-ui-triaged> |
| Status: | CLOSED DUPLICATE | QA Contact: | Bogdan Gheorghe <gheorghe> |
| Severity: | major | ||
| Priority: | P3 | CC: | daniel_megert, david.matejcek, kgb_alinus89, Konstantin.Scheglov, Lars.Vogel, nyouna, ramejan, remy.suen, thatnitind, tom.schindl |
| Version: | 4.2 | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Bug Depends on: | 421122 | ||
| Bug Blocks: | |||
| Attachments: | |||
|
Description
Andrey Loskutov
Created attachment 206176 [details]
Screenshot of 3.7 window with no e4 (ok)
Created attachment 206177 [details]
Screenshot of 4.2 window with e4 (bad)
Attached two screenshots showing same Eclipse window size on 3.7 and 4.2 e4.
(In reply to comment #0) > Either add a preference to disable the "fancy" rounded UI with wasted space or > provide a *default* theme where the space is used as efficient as in 3.7. In the 'Appearance' preference page you can switch to the 'Classic' theme. ... and just to add that we are going to provide direct customization support in 4.2. See http://ericoneclipse.blogspot.com/2011/10/eclipse-4-beyond-compatibility.html which shows the CSS-Editor in action and one more note you very likely have to restart so that the padding changes take place because they are not dynamically applied IIRC. (In reply to comment #3) > (In reply to comment #0) > > Either add a preference to disable the "fancy" rounded UI with wasted space or > > provide a *default* theme where the space is used as efficient as in 3.7. > > In the 'Appearance' preference page you can switch to the 'Classic' theme. First, why Eclipse set such not usable theme default one? Additionally, even after restarting Eclipse (another issue: nobody told me that I need it, earlier there was a dialog) issue 4) is still there. So there is the updated list 1-3) solved by Classic theme 4) View/editor minimize/maximize buttons are way to huge 5) There is no dialog showing me that I have to reboot to apply all settings 6) Classic theme is not default OR unusable theme is default (In reply to comment #4) > ... and just to add that we are going to provide direct customization support > in 4.2. See > http://ericoneclipse.blogspot.com/2011/10/eclipse-4-beyond-compatibility.html > which shows the CSS-Editor in action I guess no one of my colleagues will like to customize new workspaces each time. Some create new workspaces each week. Come on, default theme must be professionally made. Eclipse should not repeat same mistakes like Canonical with Unity. (In reply to comment #6) > (In reply to comment #3) > > (In reply to comment #0) > > > Either add a preference to disable the "fancy" rounded UI with wasted space or > > > provide a *default* theme where the space is used as efficient as in 3.7. > > > > In the 'Appearance' preference page you can switch to the 'Classic' theme. > > First, why Eclipse set such not usable theme default one? > Additionally, even after restarting Eclipse (another issue: nobody told me that > I need it, earlier there was a dialog) issue 4) is still there. > > So there is the updated list > 1-3) solved by Classic theme > 4) View/editor minimize/maximize buttons are way to huge > 5) There is no dialog showing me that I have to reboot to apply all settings I think this is a problem of the our rendering engine which uses the css-padding and sets the value on the SWT-Layout but for safety reason this might be a good idea. Created attachment 206233 [details] Screenshot depicting the behaviour in question. (In reply to comment #6) > 4) View/editor minimize/maximize buttons are way to huge I think this is an artifact of the part's title using a large font for you. It looks okay for me on Windows. > 5) There is no dialog showing me that I have to reboot to apply all settings Opened bug 362522 for this. (In reply to comment #8) > > 4) View/editor minimize/maximize buttons are way to huge > > I think this is an artifact of the part's title using a large font for you. It > looks okay for me on Windows. So must be Linux (or at least non-Windows) specific, as 3.7 has not such big icons on same desktop for me. > > 5) There is no dialog showing me that I have to reboot to apply all settings > > Opened bug 362522 for this. Thanks. (In reply to comment #9) > (In reply to comment #8) > > > 4) View/editor minimize/maximize buttons are way to huge > > > > I think this is an artifact of the part's title using a large font for you. It > > looks okay for me on Windows. > > So must be Linux (or at least non-Windows) specific, as 3.7 has not such big > icons on same desktop for me. Hold on, your Windows? screenshot shows a lot more padding around minimize/close icons as usual, at least in my opinion. I can't compare it right now, could you check it on the same workstation and 3.7? And on Linux, not the icons are huge, but the surrounding space, so it must be platform neutral. (In reply to comment #10) > Hold on, your Windows? screenshot shows a lot more padding around > minimize/close icons as usual, at least in my opinion. If you mean the padding, then yes, there's more padding now. However, the problem ultimately goes away if you switch to the 'Classic' theme. You may still notice a slight difference since they are actual tool items now (instead of custom drawn in 3.x). Created attachment 206234 [details] 4.2 "Classic" theme on Ubuntu 11.04 with Gnome desktop (bad) (In reply to comment #11) > If you mean the padding, then yes, there's more padding now. However, the > problem ultimately goes away if you switch to the 'Classic' theme. It does not, at least not on Linux (Ubuntu 11.04 64 bit, Gnome desktop, see screenshot). Compare the new screenshot with the first one (3.7). > You may > still notice a slight difference since they are actual tool items now (instead > of custom drawn in 3.x). This could be the root cause for the regression. (In reply to comment #12) > > You may > > still notice a slight difference since they are actual tool items now (instead > > of custom drawn in 3.x). > > This could be the root cause for the regression. In terms of physical pixel height they are identical. Unless your concern is a) the horizontal pixel width and/or b) that they are more centered as opposed to be aligned to the top right. Created attachment 206237 [details] 3.7 with 4.2 side by side (minimize/close buttons) (In reply to comment #13) > In terms of physical pixel height they are identical. Unless your concern is a) > the horizontal pixel width Yes. (In reply to comment #14) > (In reply to comment #13) > > In terms of physical pixel height they are identical. Unless your concern is a) > > the horizontal pixel width > Yes. Not sure if there's anything to be done here since the intent was to make those buttons real items instead of being custom drawn. (In reply to Andrey Loskutov from comment #0) > Build Identifier: Build id: I20111028-1100 > > AS IS: > Since e4 there are many places where UI is not efficiently uses space: > > 1) place between views/editor stacks is wider as before and "eats" 10 pixel > (and looks unprofessional). > 2) 3 pixel too much between main toolbar and editor area > 3) 3 pixel too much between view/editor area and its borders > 4) view/editor minimize/maximize buttons are way to huge Thanks Andrey. Could you open a separate bug for 4.) as this requires a fix in the MinMaxAddon. For the reduction of whitespace I have a suggested patch in Bug 420238, I therefore mark this one as duplicate. *** This bug has been marked as a duplicate of bug 420238 *** (In reply to Lars Vogel from comment #16) > Thanks Andrey. Could you open a separate bug for 4.) as this requires a fix > in the MinMaxAddon. bug 421122 |