Bugzilla – Full Text Bug Listing
| Summary: | [QuickAccess] Regression: "Quick access" panel lacks major usability features from 3.x stream | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Andrey Loskutov <loskutov> | ||||||||||
| Component: | UI | Assignee: | Dean Roberts <dean.t.roberts> | ||||||||||
| Status: | VERIFIED FIXED | QA Contact: | Remy Suen <remy.suen> | ||||||||||
| Severity: | major | ||||||||||||
| Priority: | P3 | CC: | dean.t.roberts, pwebster, remy.suen | ||||||||||
| Version: | 4.2 | Flags: | pwebster:
review+
|
||||||||||
| Target Milestone: | 4.2 M4 | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | All | ||||||||||||
| Whiteboard: | |||||||||||||
| Bug Depends on: | 363582 | ||||||||||||
| Bug Blocks: | 320673 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Andrey Loskutov
#4 is covered by another bug, and #2 it must be opened under the quick access search field. But it should be large enough, we should save the size if it is resized, and we definitely want the Previous Choices back. PW (In reply to comment #1) > But it should be large enough, we should save the size if it is resized I'm just wondering what is the reason to include this as a *permanent* search field on the *main* toolbar? It just doesn't fit there, or at least not as a *permanent* text field. You can NOT make it larger as now, as then you will waste even more toolbar space. Why not to show/hide this field, like Opera/Firefox does it for the in-page text search field (in Opera: F3, in Firefox: Ctrl+F)? This way you also will get more place for additional option checkboxes etc. BTW, if somebody decided that Ctrl+3 popup was not good enough for some reasons, could one please explain me, how the new solution (including all it's new bugs and missing features) is better then the old one? Why one need to re-invent the wheel again and spend time and resources for it, if it was already there, *working just fine*? I can't really believe that there were no other more important and/or broken things in Eclipse to work on. (In reply to comment #2) > You can NOT make it larger as now, as then you will > waste even more toolbar space. My reference to large enough was in response to your comment about when the dropdown list opened, it was too small. The dropdown list should be reasonably large to begin with, and if enlarged by the user that should be remembered. Not making the search box itself larger. PW Created attachment 206850 [details] Remember size after re-size Attaching a patch that will remember the size after a re-size. The size is persisted across workbench invocations. I also modified some multiple monitor code to get better behaviour for the resized window on multiple monitor setups. When applying this patch, you should make sure the patch for bug 363582 is applied first, to avoid patch mismatch problems. Created attachment 206851 [details]
Screen shot showing default QuickAssist size
Item #1 also mentioned that the original window size is too narrow. I've attached a screen shot of the original window size on my system. At least on my system, I find the initial size acceptable. Are you experiencing something different?
For item #3, I see previous choices when I invoke the QuickAccess either via Ctrl+3 or typing directly in the search bar. The previous choices will appear initially, but will disappear once you start typing, if they don't match the text you have typed so far. I believe this is desired and expected behaviour. Created attachment 206867 [details]
Screenshot of quick access on 3.7
Created attachment 206870 [details]
Screenshot of quick access on 4.2
You have right, don't know how I've tested before, but now I see the "Previous choices" too.
Regarding the appearance / size - just compare two screenshots made on the same PC. The quick access from 3.7 is more useful/ergonomic, as it is *much bigger* and appears *centered* on the wide screen.
NO ONE expects to see a "choice dialog" in the top right corner. Have you ever asked why all this "error/info/question/go to" dialogs are centered? That's simple, because user's attention is there.
Beside this, current (4.2) state is simply inconsistent to the rest of the "go to" dialogs. Open "Open resource / Type" dialogs. Do they appear in the upper right corner and have such small size? Why not?
Released to http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=81ba643bf096f3c32b01b8b85d07dcc63943ac65 PW #1 is fixed by attached (and released) patch #2 works as intended #3 works for me ... IE pervious choices are displayed #4 is covered by another bug (as per comment 2) So closing this defect as fixed Verified on I20111205-2330 |