Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 362368

Summary:

[Accessibility] Search form lacks role="button" and violates W3c guidelines

Product:

[Eclipse Project] Platform

Reporter:

Neal Timpe <natimpe>

Component:

User Assistance

Assignee:

Steve Francisco <stephen.francisco>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

ChrisAustin, pwebster, remy.suen, stephen.francisco

Version:

4.2

Keywords:

accessibility

Target Milestone:

3.7 M4

Flags:

ChrisAustin: review+

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
use type="submit" for submit buttons in search form	ChrisAustin: iplog+

Description Neal Timpe

2011-10-28 16:32:17 EDT

Build Identifier: 3.1 and 3.6

The search bar lacks a role="button" label in its div.

It violates guideline 3.2b in W3c.  The violation on type="button". Is the button a submit button?  It is not defined in that way in the code.

Suggested fix: role="button" type="submit"


<form  name="searchForm"   onsubmit="doSearch()">
199 		 		 <table id="searchTable" align="left" valign="middle" cellspacing="0" cellpadding="0" border="0">
200 		 		 		 <tr nowrap  valign="middle">
201 		 		 		 		 <td  id="searchTD">
202 		 		 		 		 		 <label id="searchLabel" for="searchWord" accesskey="s">
203 		 		 		 		 		 &nbsp;<u STYLE="ACCELERATOR:true">S</u>earch
204 		 		 		 		 		 </label>
205 		 		 		 		 </td>
206 		 		 		 		 <td>
207 		 		 		 		 		 
<input type="text" id="searchWord" name="searchWord" value='' size="24" maxlength="256" alt='Search Expression' title='Search Expression'>
208 		 		 		 		 </td>
209 		 		 		 		 <td >
210 		 		 		 		 		 &nbsp;<input type="button" onclick="this.blur();doSearch()" value='GO' id="go" alt='GO' title='GO'>
211 		 		 		 		 		 <input type="hidden" name="maxHits" value="500" >
212 		 		 		 		 </td>

Reproducible: Always

Steps to Reproduce:
Steps to Reproduce:
1. Open an eclipse page
2. Use Firebug to focus on the code in the search bar.

Comment 1 Neal Timpe

2011-11-08 09:36:38 EST

URL
https://idoc2.swg.usma.ibm.com/lotuslive/index.jsp?topic=/com.ibm.lotuslive.activities.doc/w_oa_t_notifying_members_about_an_entry.html

Checklist 
http://w3-03.ibm.com/able/devtest/webautofocus.html

Comment 2 Steve Francisco

2011-11-11 15:07:33 EST

Created attachment 206873 [details]
use type="submit" for submit buttons in search form

Comment 3 Steve Francisco

2011-11-11 15:09:26 EST

Chris, please review.  the change is to use type="submit" instead of type="button" to properly identify the purpose of the button according to the guidelines.

Comment 4 Chris Austin

2011-11-16 10:38:18 EST

Patch looks good.

Patch committed to master.