Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 362365

Summary: [Accessibility] Search table lacks role="presentation" tag and fails W3C accessibility guidelines
Product: [Eclipse Project] Platform Reporter: Neal Timpe <natimpe>
Component: User AssistanceAssignee: platform-ua-inbox <platform-ua-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: ChrisAustin, pwebster, remy.suen, stephen.francisco
Version: 4.2Keywords: accessibility
Target Milestone: 3.8 M4   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
patch to add role=presentation to search panels none

Description Neal Timpe CLA 2011-10-28 16:11:50 EDT
Build Identifier: 3.1 and 3.6

The table ID must include role="presentation" tag in a div to identify the headers. It violates guideline 1.3e. The violation occurs in the pop-up search and print tool in the TOC.

For a data table (i.e., the table tag does not contain a WAI-ARIA 'presentation' role), identify headers for the table rows and columns.

The test tool picked up the table tag and teh id="searchTable and flagged the violation. 

Violation flagged on line number 199

196 <body dir="ltr" onload="onloadHandler()"  onunload="closeAdvanced()">
197 
198 		 <form  name="searchForm"   onsubmit="doSearch()">
199 		 		 <table id="searchTable" align="left" valign="middle" 
cellspacing="0" cellpadding="0" border="0">
200 		 		 		 <tr nowrap  valign="middle">
201 		 		 		 		 <td  id="searchTD">
202 		 		 		 		 		 <label id="searchLabel" for="searchWord" accesskey="s">
203 		 		 		 		 		 &nbsp;<u STYLE="ACCELERATOR:true">S</u>earch
204 		 		 		 		 		 </label>

Reproducible: Always

Steps to Reproduce:
1. Open an eclipse page
2. Use Firebut to focus on the code in the TOC when the search and print table pops up.
Comment 2 Paul Webster CLA 2011-11-08 09:48:41 EST
This is an Eclipse Foundation bug ... please provide a URL that resolves externally, internal IBM sites don't help the Foundation.

PW
Comment 3 Steve Francisco CLA 2011-11-11 14:48:20 EST
Created attachment 206871 [details]
patch to add role=presentation to search panels
Comment 4 Steve Francisco CLA 2011-11-11 14:50:51 EST
Chris could you review this change and commit?  the change is to add:
role="presentation"
to <table> elements for search panels so that accessibility readers can ignore the fact that there is a table around the search field.  ie, it's just for presentation purposes that a table was used, and the user wouldn't benefit from hearing "cell 1 contains "Search"" and "cell 2 contains a text field".
Comment 5 Steve Francisco CLA 2011-11-24 13:54:13 EST
Comment on attachment 206871 [details]
patch to add role=presentation to search panels

this patch is obsolete. The patch on bug #362364 includes the changes needed for this fix.
Comment 6 Chris Austin CLA 2011-11-29 12:01:34 EST
This has been fixed in Bug 362364.