Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 362364

Summary:

[Accessibility] Eclipse TOC lacks WAI-ARIA landmarks for search and fails w3C

Product:

[Eclipse Project] Platform

Reporter:

Neal Timpe <natimpe>

Component:

Assignee:

Steve Francisco <stephen.francisco>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

ChrisAustin, pwebster, remy.suen, stephen.francisco

Version:

4.2

Keywords:

helpwanted

Target Milestone:

3.8 M4

Flags:

ChrisAustin: review+

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
patch to add role="search" around search entities	none
fix for both 362364 and 362365	ChrisAustin: iplog+

Description Neal Timpe

2011-10-28 15:55:29 EDT

Build Identifier: 3.1 and 3.6

The search bar in the Eclipse workbench is not contained by a div that contains the role="search" label. It fails the W3C guidelines for accessibility

This example shows a violation that was flagged on line number 199, but look on line 214 to see what the table describes

196 <body dir="ltr" onload="onloadHandler()"  onunload="closeAdvanced()">
197 
198 		 <form  name="searchForm"   onsubmit="doSearch()">
199 		 		 <table id="searchTable" align="left" valign="middle" 
cellspacing="0" cellpadding="0" border="0">
200 		 		 		 <tr nowrap  valign="middle">
201 		 		 		 		 <td  id="searchTD">
202 		 		 		 		 		 <label id="searchLabel" for="searchWord" accesskey="s">
203 		 		 		 		 		 &nbsp;<u STYLE="ACCELERATOR:true">S</u>earch
204 		 		 		 		 		 </label>
205 		 		 		 		 </td>
206 		 		 		 		 <td>
207 		 		 		 		 		 <input type="text" 
id="searchWord" name="searchWord" value='' size="24" maxlength="256" 
alt='Search Expression' title='Search Expression'>
208 		 		 		 		 </td>
209 		 		 		 		 <td >
210 		 		 		 		 		 &nbsp;<input type="button" onclick="this.blur();doSearch()" value='GO' id="go" alt='GO' title='GO'>
211 		 		 		 		 		 <input type="hidden" 
name="maxHits" value="500" >
212 		 		 		 		 </td>
213 		 		 		 		 <td nowrap>
214 		 		 		 		 		 <a id="scopeLabel" 
href="javascript:openAdvanced();" title='Select Search Scope' 
alt='Select Search Scope' onmouseover="window.status='Select Search Scope'; 
return true;" onmouseout="window.status='';">Search scope:</a>
215 		 		 		 		 </td>
216 		 		 		 		 <td nowrap>
217 		 		 		 		 		 
<input type="hidden" name="workingSet" value='All topics'>
218 		 		 		 		 		 <div id="scope" >All topics</div>






Reproducible: Always

Steps to Reproduce:
1. Open an eclipse plug-in
2. Use Firebug to view the source. 
3. Click the search bar to expand the code around the search bar.

Comment 1 Neal Timpe

2011-10-28 16:18:06 EDT

It fails W3c guidline 2.4a.

Comment 2 Paul Webster

2011-11-03 06:54:53 EDT

Please provide a link to the failing page.

Also, a link to the guideline you are citing.

PW

Comment 3 Neal Timpe

2011-11-08 09:39:10 EST

URL
https://idoc2.swg.usma.ibm.com/lotuslive/index.jsp?topic=/com.ibm.lotuslive.activities.doc/w_oa_t_notifying_members_about_an_entry.html

Checklist
http://w3-03.ibm.com/able/devtest/webnavigation.html

Comment 4 Steve Francisco

2011-11-14 12:51:31 EST

Once the 'role="search"' is added around the search fields, how can I confirm it is behaving properly?  Please give steps to show that the change did what was intended.

Comment 5 Neal Timpe

2011-11-14 13:55:53 EST

The violation was flagged by the Rational Policy tester. I think the fact that it appears should fix the problem. The violation wasn't flagged through a manual test.

Comment 6 Steve Francisco

2011-11-14 14:34:29 EST

Created attachment 206985 [details]
patch to add role="search" around search entities

Comment 7 Steve Francisco

2011-11-14 14:34:58 EST

Chris, please review this patch and commit if it's ok.

Comment 8 Chris Austin

2011-11-16 10:51:58 EST

(In reply to comment #7)
> Chris, please review this patch and commit if it's ok.

Steve, it looks like the patch is not applied as expected, now that I have committed your last patch.  Can you synchronize your local repository and verify the patch is as expected, or create a new one?

Comment 9 Steve Francisco

2011-11-24 13:52:49 EST

Created attachment 207498 [details]
fix for both 362364 and 362365

This patch adds role="search" and role="presentation" for search fields in help panels for accessibility improvements. Note that the one patch will fix bug #362364 and #362365.

Comment 10 Chris Austin

2011-11-29 11:55:16 EST

Revised patch looks good.  Patch committed to master, integration.

http://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/?id=2772cf723d8ba3c665c2cbf23e68e6cda84d0fbe