Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 362358

Summary:

Better policy ... enforce denyNonFastforwards = true

Product:

Community

Reporter:

David Williams <david_williams>

Component:

Git

Assignee:

Eclipse Webmaster <webmaster>

Status:

RESOLVED DUPLICATE

QA Contact:

Severity:

normal

Priority:

CC:

caniszczyk, contact, daniel_megert, david_williams, deepakazad, dj.houghton, hargrave, irbull, john.arthorne, kim.moir, markus.kell.r, matthias.sohn, michael.wenz, Mike_Wilson, mober.at+eclipse, ob1.eclipse, overholt, pwebster, remy.suen, sbouchet, sptaszkiewicz, steffen.pingel, stephan.herrmann, stepper, tjwatson, tomasz.zarna, wayne.beaton

Version:

unspecified

Target Milestone:

---

Hardware:

OS:

Linux

Whiteboard:

Bug Depends on:

Bug Blocks:

362076

Attachments:

Description	Flags
list of files matching denyNonFastforwards = true	none
list of files matching sharedrepository = 1	none

Description David Williams

2011-10-28 15:20:03 EDT

+++ This bug was initially created as a clone of Bug #362076 +++

In the cloned bug, I mentioned that the default when git init --shared was used, was to automatically set denyNonFastforwards = true. 

But ... I checked ... and appears not to be the case for all our git repos. Not sure how they were created ... but I did a little "survey" and found there are 53 that have sharedrepository = 1 but do NOT have denyNonFastforwards = true. 

I did this just using "grep" so, might not be perfect, but, from the main git directory,  

grep --include=config -r "sharedrepository.*1" * 2>&1 | tee ~/temp/gitshared2.tx

resulted in 193 files matching where as 

grep --include=config -r "denyNonFastforwards.*true" * 2>&1 | tee ~/temp/gitdenyNonFastforwards2.txt

resulted in only 140 files matching. Hence, concluded at least 53 missing denyNonFastforwards = true. 

I suggest the webmasters, somehow, go in and add that configuration flag. 

From bug 362076 seems this should be non-controversial, but suspect it should be announced in some manner in case some of the effected projects would not be expecting it. 

I'll attach my results ... but, don't take my word for it ... would be nice if there was some smooth way to do this, rather an a little perl script :) ... but, I'll need to learn a lot more about git before I could suggest anything.

Comment 1 David Williams

2011-10-28 15:23:59 EDT

Created attachment 206151 [details]
list of files matching denyNonFastforwards = true

Comment 2 David Williams

2011-10-28 15:24:50 EDT

Created attachment 206152 [details]
list of files matching sharedrepository = 1

Comment 3 Andrew Overholt

2011-10-28 15:30:30 EDT

See also bug 343150.  Maybe this or that are dupes of each other.

Comment 4 David Williams

2011-10-28 16:36:36 EDT

Yep, good dup. Opened 6 months ago. Thanks for pointing it out.

*** This bug has been marked as a duplicate of bug 343150 ***