Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 362355

Summary:	Mac test failure in I20111027-1800
Product:	[Eclipse Project] Platform	Reporter:	John Arthorne <john.arthorne>
Component:	Resources	Assignee:	Szymon Brandys <Szymon.Brandys>
Status:	RESOLVED WORKSFORME	QA Contact:
Severity:	normal
Priority:	P3
Version:	4.2
Target Milestone:	---
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description John Arthorne

2011-10-28 14:39:30 EDT

I've never noticed this test failure before...


junit.framework.AssertionFailedError: null
at org.eclipse.core.tests.resources.session.TestBug297635.assertStateTrees(TestBug297635.java:164)
at org.eclipse.core.tests.resources.session.TestBug297635.test2(TestBug297635.java:126)
at org.eclipse.jdt.internal.junit.runner.junit3.JUnit3TestReference.run(JUnit3TestReference.java:130)
at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390)
at org.eclipse.pde.internal.junit.runtime.RemotePluginTestRunner.main(RemotePluginTestRunner.java:62)
at org.eclipse.pde.internal.junit.runtime.CoreTestApplication.run(CoreTestApplication.java:23)
at org.eclipse.equinox.internal.app.EclipseAppContainer.callMethodWithException(EclipseAppContainer.java:587)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:198)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:352)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:624)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:579)
at org.eclipse.equinox.launcher.Main.run(Main.java:1431)
at org.eclipse.equinox.launcher.Main.main(Main.java:1407)
at org.eclipse.core.launcher.Main.main(Main.java:34)

Comment 1 John Arthorne

2011-10-28 14:55:06 EDT

It looks to me like this test is vulnerable to a background snapshot operation happening. It basically does the following:

1) register save participant
2) assert saved tree is non-null
3) perform a snapshot
4) assert saved tree is null

However if a background snapshot started by a previous test caused 3) to happen before 2), the test would fail.

Comment 2 John Arthorne

2011-10-28 15:02:48 EDT

Szymon does anyone on your team run on Mac?

Comment 3 Szymon Brandys

2011-10-31 07:03:39 EDT

(In reply to comment #2)
> Szymon does anyone on your team run on Mac?

I have a Mac on my desk. It failed again in N20111028-2000, but is fine in N20111029-2000. I'll check locally on my Mac.

Comment 4 Szymon Brandys

2011-11-02 08:07:24 EDT

(In reply to comment #3)
> (In reply to comment #2)
> > Szymon does anyone on your team run on Mac?
> 
> I have a Mac on my desk. It failed again in N20111028-2000, but is fine in
> N20111029-2000. I'll check locally on my Mac.

Does not fail locally and recent builds look fine too.

Comment 5 Szymon Brandys

2011-11-09 06:05:24 EST

(In reply to comment #4)
> Does not fail locally and recent builds look fine too.

I could not reproduce the problem locally and builds still look fine. Marking this WORKSFORME. Feel free to reopen, if you find steps or it starts failing again.