Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 362203

Summary: Entity Gen Wizard: Manually input table names are not counted on Association Tables page
Product: [WebTools] Dali JPA Tools Reporter: Nan Li <nan.n.li>
Component: GeneralAssignee: Nan Li <nan.n.li>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: jolene.moffitt, neil.hauge
Version: unspecifiedFlags: neil.hauge: review+
Target Milestone: 3.3 M2   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
Proposed Patch neil.hauge: iplog+

Description Nan Li CLA 2011-10-27 10:35:44 EDT 
Build Identifier: M20110909-1335

1. Bring up entity gen wizard and go to Table Associations page
2. Click New Association button to open Association Tables page
3. Select a table for Table 1 and Table 2 field separately
4. Change the table names by manually input values to the fields and click Next

The table names shown on the next page are ones set at step 3 instead of the manually input values at step 4. The better way to do this could be taking the manually input the values and validate their existence before being able to pursue to the next page.


Reproducible: Always
Comment 1 Nan Li CLA 2012-04-26 13:12:01 EDT 
Created attachment 214617 [details]
Proposed Patch

The solution is to validate the value entered either manually or by selecting from the table list. It cannot be proceeded to the next page if any table is not specified or any given table does not exist, and thereby prevents invalid input for the next page which may later lead to exceptions.
Comment 2 Neil Hauge CLA 2012-07-05 17:02:40 EDT 
I wonder if there is even a reason that these table entry fields should be editable.  I suppose some users might want to type the name in manually, so since this patch already adds the necessary validation, that should be fine.

Hmm.  It seems even with valid tables, add association on the next page fails, but that would be an unrelated bug.

Patch is committed to head.
Comment 3 Nan Li CLA 2012-09-11 17:55:04 EDT 
Part of the join table related changes for this bug was rolled back because of bug 364093. Please reference the changes in the additional patch of bug 364093.
Comment 4 Nan Li CLA 2012-09-12 11:07:18 EDT 
No changes were rolled back. Please reference bug 364093 for details.
Comment 5 Jolene Moffitt CLA 2012-10-16 13:37:13 EDT 
Verified in build I-3.5.0-20121003040013 that you need to enter valid Table names in the Create New Association dialog in order to have the Next button become enabled.  To view steps to verify this issue go to http://wiki.eclipse.org/Dali_3.3_M2_Release