Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 362195

Summary:	[Utils] ICatalogManager#setCatalogSet
Product:	z_Archived	Reporter:	Nicolas Bros <nicolas.bros>
Component:	EMF-Facet	Assignee:	Project Inbox <emft.facet-inbox>
Status:	NEW ---	QA Contact:
Severity:	normal
Priority:	P5	CC:	gdupe
Version:	unspecified	Flags:	gdupe: juno+ gdupe: kepler+
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:

Description Nicolas Bros

2011-10-27 09:48:37 EDT

The method setCatalogSet in the interface ICatalogManager feels backwards: it is called setCatalogSet, but it in fact does not set the CatalogSet but adds the catalog to the list of catalogs in the CatalogSet.

I think this method should be replaced by:
ICatalogManager#getCatalogSet(), that would return the org.eclipse.emf.facet.util.emf.catalog.Catalog managed by the ICatalogManager. And the ICatalogSetManager which owns and is responsible for its CatalogSet should also be responsible for adding the catalogs to its CatalogSet.

Comment 1 Nicolas Bros

2011-10-27 10:08:58 EDT

(In reply to comment #0)
> I think this method should be replaced by:
> ICatalogManager#getCatalogSet()
I meant:
ICatalogManager#getCatalog()