Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 362192

Summary:	Build Project doesn't ask for "save first"
Product:	[Eclipse Project] Platform	Reporter:	Michael N. Lipp <mnl>
Component:	UI	Assignee:	Platform-UI-Inbox <Platform-UI-Inbox>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	normal
Priority:	P3	CC:	angvoz.dev, ilke.muhtaroglu, john.arthorne, l.felber, mnl, pwebster, remy.suen, Szymon.Brandys, yevshif
Version:	3.7
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
Whiteboard:	stalebug

Description Michael N. Lipp

2011-10-27 09:30:31 EDT

Build Identifier: 20110916-0149

When I have changed a file in a C++ project, haven't saved it yet (!) and try to run it, a dialog pops up that asks wether I want to save the file first.

This dialog does not show up when I build the project. Build uses the file on disk without making me aware that I have changed the file in the editor and not saved it yet.

This behaviour is inconsistent. Build project should also check and pop up the dialog.

Reproducible: Always

Steps to Reproduce:
1. Change source file
2. Do NOT save it
3. Run project/build

Comment 1 Andrew Gvozdev

2011-10-27 11:05:03 EDT

There are 2 separate preferences controlling the behavior (both in Platform, not CDT):
1. General->Workspace-> Save automatically before build (disabled by default)
2. Run/Debug->Launching-> Save required dirty editors before launching (Prompt by default)

It is fair for a user to say that behavior is inconsistent, perhaps the settings should be consolidated?

Comment 2 Paul Webster

2011-11-02 15:10:23 EDT

The preferences control for building (a manual build, not automatic, right?) seems to be the inverse of the Launching one.

John, what do you think would be a good path forward for the building preference?  On the first manual build open a similar dialog to the launch one, and give the user the choice (yes, no) and an option to "don't ask me again".

Since that pref has probably been there for a long time, I'm hesitant to change it.

PW

Comment 3 Andrew Gvozdev

2011-11-06 14:27:27 EST

*** Bug 337961 has been marked as a duplicate of this bug. ***

Comment 4 Remy Suen

2011-11-18 14:44:58 EST

(In reply to comment #2)
> The preferences control for building (a manual build, not automatic, right?)
> seems to be the inverse of the Launching one.
> 
> John, what do you think would be a good path forward for the building
> preference?  On the first manual build open a similar dialog to the launch one,
> and give the user the choice (yes, no) and an option to "don't ask me again".
> 
> Since that pref has probably been there for a long time, I'm hesitant to change
> it.

Don't see John on the CC list.

Comment 5 John Arthorne

2011-11-21 16:47:34 EST

I guess in theory it should be changed to a three state preference (Always/Never/Prompt). I really hate those automatic popups though. Consider also since "Build before launch" is also enabled by default, the default behaviour becomes:

- Edit a file, don't save
- Ctrl+B to build
-> Do you want to save before build? Click no
-> Do you want to save before launch? Click no

I would argue if "save before build" and "build before launch" are both on by default (or at least prompting), then "save before launch" should be turned off.

Comment 6 Eclipse Genie

2020-04-28 00:56:12 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.