Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 362144

Summary: EDT Supports more database vendors
Product: z_Archived Reporter: Zhi Zhu <zhuzhi>
Component: EDTAssignee: Justin Spadea <jspadea>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: chenzhh, jspadea, svihovec, yuhaodl
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:

Description Zhi Zhu CLA 2011-10-26 22:44:04 EDT 
1. DB2
2. Derby
3. Informix
4. MySQl
5. Oracle
6. SQL Server
  the above is already supported

  Below is newly added:
7. HSQLDB
8. Ingres
9. MaxDB
10. PostgreSQL
11. SQLite
12. Sybase ASA
13. Sybase ASE
Comment 1 Zhi Zhu CLA 2011-10-27 02:43:06 EDT 
SQLDatabaseBindingDetailPage.java
SQLConstants.java
EGLSQLUtility.java
EGLConnectibleDatabases.java
Comment 2 Justin Spadea CLA 2011-10-27 09:01:17 EDT 
This has been brought up before, and what we need to do is remove all of the vendor filtering so that everything gets displayed, instead of adding missing vendors to the "allowed" list. If the user installs a plug-in for some new database, they won't see it when using our tooling (even though it will show up in other parts of the IDE like Data perspective).

The only reason we had filtering with RBD is because we only supported specific vendors. EDT generates the same SQL code regardless of vendor, so we are going to claim support for certain vendors and then state "we expect the other vendors will work too, but they haven't been tested".
Comment 3 Zhi Zhu CLA 2011-10-28 00:04:48 EDT 
Tony & Brian:
  Can you decide which vendors should be supported? so I can do based on your comments.

thanks
Comment 4 Zhi Zhu CLA 2011-10-28 00:06:26 EDT 
Justin:
  Now we supported all vendors Eclipse supports, do we need support others?
Comment 5 Brian Svihovec CLA 2011-10-28 14:08:37 EDT 
Zhi Zhu, 

I talked about this issue with Justin, and the more we talked, the more code we found that needs to be removed due to some invalid assumptions we made at the beginning of the EDT project in the area of Database connections.

After our discussion, Justin and I agreed that it would be easier if he cleans up the code that is no longer required, and while we are it it, he can fix the vendor list.  

Due to the fact that we do not generate vendor specific code, we are going to remove all vendor filtering and modify our database connection wizard to re-use all of the existing code from Eclipse.  In the future, if we find that we do need to do any filtering, we can revert to the old code that is in CVS.
Comment 6 Justin Spadea CLA 2011-10-31 15:10:55 EDT 
The code has been removed from the SQL plug-in, and the SQL binding detail page has been updated due to changes in EGLSQLUtility.
Comment 7 Zhi Zhu CLA 2011-11-08 01:34:51 EST 
Verify and close it