Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 362029

Summary:	[builder] ToBeBuilt contains same URI in toBeUpdated and toBeDeleted
Product:	[Modeling] TMF	Reporter:	Knut Wannheden <knut.wannheden>
Component:	Xtext	Assignee:	Project Inbox <tmf.xtext-inbox>
Status:	NEW ---	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	sebastian.zarnekow
Version:	2.1.0
Target Milestone:	---
Hardware:	PC
OS:	Mac OS X - Carbon (unsup.)
Whiteboard:

Description Knut Wannheden

2011-10-26 02:42:05 EDT

When invoking ToBeBuiltComputer#updateProject() (which happens when a full build is executed) a ToBeBuilt object is returned which contains many URIs both in the toBeUpdated *and* toBeDeleted sets. This seems wrong or at least unnecessary: Either a resource should be updated or deleted.

We should check if we can change the logic in ToBeBuiltComputer (and JdtToBeBuiltComputer) to return ToBeBuilt objects where an URI can only occur in either of the sets. If all tests still are green, I suggest we commit the change.

Comment 1 Sebastian Zarnekow

2011-10-26 02:45:14 EDT

(In reply to comment #0)
> If all tests still are green, I suggest we commit the change.

Please not before 2.1

Comment 2 Knut Wannheden

2011-10-26 03:24:48 EDT

(In reply to comment #1)
> Please not before 2.1

Agreed.

Comment 3 Sebastian Zarnekow

2013-04-19 05:44:39 EDT

Knut, do you remember the impact of the change?

Comment 4 Knut Wannheden

2013-04-19 19:25:25 EDT

No, I am afraid not. Possibly it doesn't have any effect in the standard builder implementation. I will try to verify that.

Do you think you have found a problem which may be due to this?

Comment 5 Sebastian Zarnekow

2013-04-22 03:05:33 EDT

No, I did not find a problem related to this behavior, but just stumbled across this ticket while browsing the backlog.