Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 361947

Summary:

Boolean arguments are not checked for valid state

Product:

[WebTools] JSDT

Reporter:

Hernan Pepe Petersen <hernanpepe>

Component:

Debug

Assignee:

Michael Rennie <Michael_Rennie>

Status:

RESOLVED FIXED

QA Contact:

Michael Rennie <Michael_Rennie>

Severity:

normal

Priority:

CC:

thatnitind

Version:

unspecified

Target Milestone:

3.4 M3

Hardware:

OS:

Windows XP

Whiteboard:

Bug Depends on:

Bug Blocks:

367806

Attachments:

Description	Flags
Proposed fix	none
updated patch	none

Description Hernan Pepe Petersen

2011-10-25 11:39:52 EDT

Build Identifier: 20110615-0604

When you add your own Boolean Argument to the Debug configuration tab and define the isValid() method as false Debug button does not disable.

Reproducible: Always

Steps to Reproduce:
1.Addd a Boolean argument to the Configuration arguments and define isValid() as return false;
2. Go to a new debug configuration.
3. Enable or disable and check the Debug button.

Comment 1 Hernan Pepe Petersen

2011-10-25 11:41:11 EDT

Created attachment 205928 [details]
Proposed fix

This is the fix i've used for this to work. Thanks, Hernan.

Comment 2 Michael Rennie

2011-10-26 12:54:59 EDT

Created attachment 206004 [details]
updated patch

It makes sense to call isValid for all of the types of arguments we support for launching connectors, as such I updated the original patch to include IntegerArgument and SelectedArgument (as well as BooleanArgument)

Comment 3 Michael Rennie

2011-10-26 12:58:16 EDT

Applied second patch to HEAD