Bug 361930

Comment 1 Malgorzata Janczarska 2011-11-08 07:45:00 EST

Created attachment 206587 [details]
backported fix

Comment 2 Tomasz Zarna 2011-11-08 09:17:13 EST

In your patch, the version number for the tests plugin should synced with an associated plugin. Bumping the version only for the former smells fishy :) Please see http://wiki.eclipse.org/Version_Numbering#Plug-ins_with_no_API, and double check your patch.

Comment 3 Malgorzata Janczarska 2011-11-08 10:13:34 EST

Created attachment 206601 [details]
Backport

Comment 4 Malgorzata Janczarska 2011-11-08 10:15:40 EST

(In reply to comment #2)
> In your patch, the version number for the tests plugin should synced with an
> associated plugin. Bumping the version only for the former smells fishy :)
> Please see http://wiki.eclipse.org/Version_Numbering#Plug-ins_with_no_API, and
> double check your patch.
I've synchronized the tests version with the bundle version. The bundle version should be incremented already in bug 363158.

Comment 5 Tomasz Zarna 2011-11-09 05:04:56 EST

Please add the new test to a suite.

Comment 6 Malgorzata Janczarska 2011-11-09 05:25:29 EST

Created attachment 206659 [details]
Backport

Comment 7 Tomasz Zarna 2011-11-09 05:34:55 EST

Fixed with d251f1c995d57cb6e18d0c9380b709c5f99483d2.

Comment 8 Szymon Brandys 2012-01-23 05:35:53 EST

The fix caused a regression, see bug 339990. Since we do not have a well-tested alternative fix, I would like to rollback this backport fix. The consumer of the fix may wait till 3.7.2+.

Comment 9 Dani Megert 2012-01-23 05:53:59 EST

(In reply to comment #8)
> The fix caused a regression, see bug 339990. Since we do not have a well-tested
> alternative fix, I would like to rollback this backport fix. The consumer of
> the fix may wait till 3.7.2+.

Sounds a like a good plan to me.

Comment 10 Tomasz Zarna 2012-01-23 14:54:25 EST

(In reply to comment #8)
> The fix caused a regression, see bug 339990. 

It should read "bug 366016".

+1 for reverting the bad fix.

See also bug 360959.

Comment 11 Szymon Brandys 2012-01-24 04:32:49 EST

(In reply to comment #10)
> > The fix caused a regression, see bug 339990. 
> 
> It should read "bug 366016".

Of course. I pasted wrong bug number.

Comment 12 Tomasz Zarna 2012-01-26 07:45:05 EST

Created attachment 210111 [details]
mylyn/context/zip

Comment 13 Tomasz Zarna 2012-01-26 07:46:25 EST

The fix has been reverted as 21b71cca4ee4254a2a61abbbd771dea13406e75b 

Leaving the bug (re)open, waiting for a proper fix.

Comment 14 Szymon Brandys 2012-02-01 09:38:27 EST

This bus is 3.7.2+. Please set the target, when 3.7.2+ is added to Bugzilla.

Comment 15 Szymon Brandys 2012-05-02 05:23:37 EDT

Gosia, could you release the fix and close this bug as soon as Bug 372862 is verified?

Comment 16 Malgorzata Janczarska 2012-07-12 06:09:44 EDT

Created attachment 218630 [details]
Backport

This patch contains backport combining all fixes from this bug.

Comment 17 Szymon Ptaszkiewicz 2012-09-10 06:42:38 EDT

Szymon, we need your +1 to backport this.

Comment 18 Szymon Ptaszkiewicz 2014-04-29 05:43:31 EDT

Ping.

Comment 19 Szymon Ptaszkiewicz 2014-08-27 06:55:48 EDT

There are no plans to fix this for 3.7.2+.