Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 361851

Summary:	MAddons are not persisted in the deltas file
Product:	[Eclipse Project] Platform	Reporter:	Eric Moffatt <emoffatt>
Component:	UI	Assignee:	Remy Suen <remy.suen>
Status:	RESOLVED FIXED	QA Contact:	Remy Suen <remy.suen>
Severity:	normal
Priority:	P3	CC:	remy.suen
Version:	4.2
Target Milestone:	4.2 M4
Hardware:	All
OS:	All
Whiteboard:

Description Eric Moffatt

2011-10-24 14:38:17 EDT

I'm trying to implement a fix for Bug 360159 but in order to complete the work I need to be able to have the MinMaxAddon (at least) persist some state.

The issue of whether or not Addons *should* be persistent is still worth a discussion but the result would be to change the model. The deltas mechanism should respect the EMF model as far as what gets persisted goes I think.

Note that persisting the addons in the model will likely require added work to ensure that we aren't generating multiple instances of the same addon in the model (depending on how it's being contributed) but that's a separate issue (for which I'll open/fix a defect once the persistence is in place).

Comment 1 Remy Suen

2011-10-31 10:01:34 EDT

I've made the necessary changes so that the 'persistedState' attribute will be persisted as needed.
http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=9be6b6fe106cc6755fbb74879e7bf81570769e39

Note that changes to make the collection of addons persistent has not been implemented.