Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 361695

Summary: Proposed patch to add report extension to Overview pane
Product: [Tools] MAT Reporter: Kevin Grigorenko <kevin.grigorenko>
Component: GUIAssignee: Project Inbox <mat.gui-inbox>
Status: NEW --- QA Contact:
Severity: enhancement    
Priority: P3    
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Allow report extensions to display in Overview Pane none

Description Kevin Grigorenko CLA 2011-10-21 13:25:48 EDT 
Build Identifier: Trunk

Attached is a proposed patch which allows an org.eclipse.mat.report.report extension point to specify isInOverviewReportsList="true" so that it shows up in the list of reports in the Overview Pane when opening a dump. For example, I would like to be able to add a product overview report with the IBM Extensions for Memory Analyzer installed. I've also updated the leak suspects and top components reports to utilize this extension point attribute.

Reproducible: Always

Steps to Reproduce:
N/A
Comment 1 Kevin Grigorenko CLA 2011-10-21 13:26:28 EDT 
Created attachment 205749 [details]
Allow report extensions to display in Overview Pane
Comment 2 Andrew Johnson CLA 2011-11-23 07:35:13 EST 
How is this bug related to bug 353363 ?

I notice that currently there is also a Additional Information section added if a valid query is found named starting with "supplement_". Is this the best way of adding queries to the overview pane?
Comment 3 Kevin Grigorenko CLA 2011-11-27 22:40:17 EST 
(In reply to comment #2)
> How is this bug related to bug 353363 ?

Whoops! I forgot I had already submitted this. I'll close 353363 as DUP of this.

> 
> I notice that currently there is also a Additional Information section added if
> a valid query is found named starting with "supplement_". Is this the best way
> of adding queries to the overview pane?

I wasn't aware of this. It's a bit awkward in that it requires a prefix in the name of the query -- I think it would be better to have some type of metadata instead (for example, in the extension point XML definition). Nevertheless, this will work for my pursposes, thanks (and it seems this has been around for years)!

I still think the proposed patch is useful for reports instead of queries, but I'm fine if this bug is closed.
Comment 4 Kevin Grigorenko CLA 2011-11-27 22:41:05 EST 
*** Bug 353363 has been marked as a duplicate of this bug. ***