| Summary: | [EMF Compare UML] Update Reference difference target to the wrong targets when target is a stereotype | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Modeling] EMFCompare | Reporter: | Arthur Daussy <arthur.daussy> | ||||||
| Component: | Core | Assignee: | EMF Compare <emf.compare-inbox> | ||||||
| Status: | CLOSED FIXED | QA Contact: | |||||||
| Severity: | major | ||||||||
| Priority: | P3 | CC: | laurent.goubet | ||||||
| Version: | 1.3 | ||||||||
| Target Milestone: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Whiteboard: | |||||||||
| Bug Depends on: | 360757 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
Created attachment 205735 [details]
Possible correction
The following path could be a fix for this bug.
The fix seems good and does not provoke regressions in the current test suite. There might be other situations where we would need to "browse" to the "base" element instead of staying on the stereotype application, but for now that will do. The patch will be pushed on master with a few modifications : - author added in copyright notice of the changed class - name of the method changed from "setCorrectTarget" to "setTargets" before I commit though, I need to make sure of what you'd rather see in the copyright notice : [...] * Contributors: * Obeo - initial API and implementation * Arthur Daussy (Atos) - [361666] Fixing target of stereotype application differences *******************************************************************************/ [...] Should it be - Arthur Daussy (Atos) - Arthur Daussy (Atos Origin) - Atos ... ? Arthur Daussy (Atos) is perfect. Sorry I have forgotten to do it. I will for the next patch. > Sorry I have forgotten to do it. I will for the next patch.
No problem, this is hardly difficult for me to add :).
The patch has been pushed to master and will be available in the next 1.3 build.
batch-closing a bunch of "RESOLVED" bugs. |
Created attachment 205733 [details] Models to reproduce When updating a stereotype reference to another stereotype. The diff element always have as targets the stereotypes application elements. However if the EReference which has been updated belong the to based element then the display is not correct. How to reproduce: -> Use the two models given in attachment. -> See in the Structured View the values displayed are not correct: ... Dimension to Dimension .. instead of ... Dimension0 to Dimension1... The problem can often appear in SysML with an Value Type element which reference an Dimension Element.