Bug 361641

Description Bjoern Sundin 2011-10-21 07:51:45 EDT

Build Identifier: Build id: M20110909-1335

Referring to conversation in newsgroups: http://www.eclipse.org/forums/index.php/m/742541/#msg_742541

I encounter a problem in the generated  Dawn***CanonicalEditPolicy method getCreateViewRequest. 

In order to programmatically create a model AND diagram object (EditPart) I use to create an edit request and pass it into the semantic edit policy (getCommand). Since I started to use Dawn only the model object (semantic) is created while executing the command. The diagram edit part (canonical) is not created anymore. 

Debugging through the code I found that the ViewDescriptor that should be used to create the EditPart is getting removed inside the method getCreateViewRequest of the generated Dawn***CanonicalEditPolicy (see comment inside code):

@Override
protected CreateViewRequest getCreateViewRequest(
        List<ViewDescriptor> descriptors) {
    List<View> viewChildren = getViewChildren();

    List<ViewDescriptor> tbr = new ArrayList<CreateViewRequest.ViewDescriptor>();

    for (ViewDescriptor desc : descriptors) {
        EObject obj = (EObject) ((CanonicalElementAdapter) desc
                .getElementAdapter()).getRealObject();

        boolean found = false;

        for (View view : viewChildren) {
            if (view.getElement().equals(obj)) {
                found = true;
                break;
            }
        }
        if (!found) {
            // Comment: There was no view found for this "real 
            //          object" but why is then the descriptor
            //          added to the tbr list? Shouldn't it be 
            //          the other way around?
            tbr.add(desc);
        }
    }

    descriptors.removeAll(tbr);

    return new CreateViewRequest(descriptors);
}

(Changing 'if (!found)' to 'if (found)' handles the problem in my case)

Reproducible: Always